[功能]: 实现医院信息的分页获取 close #37 #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rexwangcc
reviewed
Jan 28, 2020
| resp['success'] = True | ||
| except Exception as e: | ||
| resp['msg'] = str(e) | ||
| return json.dumps(resp, ensure_ascii=False),(400 if not resp['success'] else 200) |
There was a problem hiding this comment.
I'm afraid this in some cases will swallow some 500 server errors and make their status codes "look like" 400 errors to API consumers, since the Exception is too broad. We might want to let endpoints throw their errors transparently and have a top-level error handler later. For now, since we don't really care about the error codes, generally I'm OK with this pagination method. What do you think? @LiuChangFreeman
rexwangcc
approved these changes
Jan 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API：http://127.0.0.1:9000/wuhan2020/hospitals?skip=${skip}&limit=${limit}
skip: 数据偏移，获取数据跳过的数据条数
limit: 获取的数据条数限制，最大为50
当不使用skip和limit参数时，则返回所有数据。