Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add submit command #370

Merged
merged 5 commits into from
Jan 30, 2024
Merged

feat: Add submit command #370

merged 5 commits into from
Jan 30, 2024

Conversation

aklinker1
Copy link
Collaborator

@aklinker1 aklinker1 commented Jan 25, 2024

This closes #57!

Adds the wxt submit and wxt submit init commands. Not using the word "publish" since npm publish is a built-in command. Naming it submit will hopefully guide people to calling their package.json scripts "submit" as well.

@aklinker1 aklinker1 self-assigned this Jan 25, 2024
Copy link

netlify bot commented Jan 25, 2024

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit 965616f
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/65b94521feb1790008617482
😎 Deploy Preview https://deploy-preview-370--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aklinker1
Copy link
Collaborator Author

Right now, I have it setup as an alias for publish-extension, and you have to pass the zips you want to upload.

I'm considering including building, zipping, and discovering all the zips in a single command. Like for example, the Firefox sources zip should never need to be passed for Firefox, WXT should know that it exists and is required.

@aklinker1
Copy link
Collaborator Author

Nope, for now, it'll just be an alias.

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (6557dfe) 80.47% compared to head (965616f) 80.38%.

Files Patch % Lines
src/cli/cli-utils.ts 76.34% 22 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #370      +/-   ##
==========================================
- Coverage   80.47%   80.38%   -0.10%     
==========================================
  Files         104      107       +3     
  Lines        7645     7727      +82     
  Branches      689      694       +5     
==========================================
+ Hits         6152     6211      +59     
- Misses       1477     1500      +23     
  Partials       16       16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aklinker1 aklinker1 marked this pull request as ready for review January 30, 2024 18:53
@aklinker1 aklinker1 merged commit 26e30aa into main Jan 30, 2024
17 checks passed
@aklinker1 aklinker1 deleted the wxt-submit branch January 30, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wxt submit
1 participant