-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ESM content script support #406
Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
// type: 'module', | ||
type: 'module', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #406 +/- ##
==========================================
- Coverage 80.59% 80.57% -0.03%
==========================================
Files 108 109 +1
Lines 7782 7875 +93
Branches 706 716 +10
==========================================
+ Hits 6272 6345 +73
- Misses 1494 1514 +20
Partials 16 16 ☔ View full report in Codecov by Sentry. |
Closing in favor of #584 |
This PR likely won't be merged, this is a complex change and I just want to see what it will look like to get dev mode working.
Add
type: "module"
to your content script options:This closes #357.
Todo