[fix](inverted index) Fix incorrect usage of regexp compile_err (apac…

…he#41944) (apache#43394) pick apache#41944
wyxxxcat · Nov 8, 2024 · 35071eb · 35071eb
1 parent 643ac39
commit 35071eb
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/be/src/vec/functions/match.cpp b/be/src/vec/functions/match.cpp
@@ -457,10 +457,11 @@ Status FunctionMatchRegexp::execute_match(FunctionContext* context, const std::s
 
     if (hs_compile(pattern.data(), HS_FLAG_DOTALL | HS_FLAG_ALLOWEMPTY | HS_FLAG_UTF8,
                    HS_MODE_BLOCK, nullptr, &database, &compile_err) != HS_SUCCESS) {
-        LOG(ERROR) << "hyperscan compilation failed: " << compile_err->message;
+        std::string err_message = "hyperscan compilation failed: ";
+        err_message.append(compile_err->message);
+        LOG(ERROR) << err_message;
         hs_free_compile_error(compile_err);
-        return Status::Error<ErrorCode::INVERTED_INDEX_INVALID_PARAMETERS>(
-                std::string("hyperscan compilation failed:") + compile_err->message);
+        return Status::Error<ErrorCode::INVERTED_INDEX_INVALID_PARAMETERS>(err_message);
     }
 
     if (hs_alloc_scratch(database, &scratch) != HS_SUCCESS) {

diff --git a/regression-test/suites/inverted_index_p0/test_no_index_match.groovy b/regression-test/suites/inverted_index_p0/test_no_index_match.groovy
@@ -113,6 +113,13 @@ suite("test_no_index_match", "p0") {
         log.info(e.getMessage());
         assertTrue(e.getMessage().contains("match_phrase_prefix not support execute_match"))
       }
+
+      try {
+          sql """ select count() from ${testTable} where (request match_regexp '?');  """
+      } catch (Exception e) {
+        log.info(e.getMessage());
+        assertTrue(e.getMessage().contains("hyperscan compilation failed: Invalid repeat at index 0."))
+      }
     } finally {
     }
 }