Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pagy requirement from >= 6, < 9 to >= 6, < 10 #548

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 1, 2024

Updates the requirements on pagy to permit the latest version.

Release notes

Sourced from pagy's releases.

Version 9.0.5

✴ What's new in 9.0+ ✴

  • Wicked-fast Keyset Pagination for big data! It works with ActiveRecord::Relation and Sequel::Dataset sets.
  • More Playground Apps to showcase, clone and develop pagy APPs without any setup on your side
  • Lots of refactorings and optimizations
  • See the Changelog for possible breaking changes

Changes in 9.0.5

  • Fix for missing variables passed to pagy_anchor from pagy_nav (closes #728)

CHANGELOG

Changelog

Sourced from pagy's changelog.

Version 9.0.5

  • Fix for missing variables passed to pagy_anchor from pagy_nav (closes #728)

Version 9.0.4

  • Fix groupdate timezone error on certain machines/config
  • Fix gem containing tmp files

Version 9.0.3

  • Remove legacy and unused javascript files
  • Improve pagy_get_page with force_integer option
  • Fix jsonapi with keyset
  • Complete the internal refactoring of version 9:
    • Remove the pagy*_get_vars methods now useless
    • Use to_i on the page variable for the search extras

Version 9.0.2

  • Rename and document the link header to pagy_link_header
  • Add first and next url helpers to the keyset extra; add the keyset section to config/pagy.rb
  • Fix nil page in keyset URL not overriding the params page
  • Extracted shared method

Version 9.0.1

  • Fix countless executing the count query
  • Rename row_comparison > tuple_comparison; ignore mixed orders

Version 9.0.0

Breaking Changes

Dropped support for deprecated stuff

  • The foundation, materialize, semantic and uikit CSS extras have been removed: (See the reasons)
  • Javascript renamed files
    • pagy.js: use pagy.min.js
    • pagy-module.js: use pagy.mjs
    • pagy-dev.js: use the pagy.min.jswith the pagy.min.js.map
    • pagy-module.d.ts: use pagy.d.ts
  • The Array type for the :size (e.g. size: [1, 4, 4, 1]) that generates the classic bar is not supported anymore: use the :size set to an integer with the ends: true variable (which are the default since 8.4.6). If a legacy bar remains REALLY a requirement, add require 'pagy/extras/size to your pagy.rb initalizer. (See the size extra)

Simple renaming

... (truncated)

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Aug 1, 2024
Copy link

netlify bot commented Aug 1, 2024

Deploy Preview for govuk-components ready!

Name Link
🔨 Latest commit 57465fd
🔍 Latest deploy log https://app.netlify.com/sites/govuk-components/deploys/66bb8e01d531a30008317029
😎 Deploy Preview https://deploy-preview-548--govuk-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@peteryates peteryates force-pushed the dependabot/bundler/pagy-gte-6-and-lt-10 branch from 8381fae to 26a4a39 Compare August 13, 2024 16:44
dependabot bot and others added 2 commits August 13, 2024 17:45
Updates the requirements on [pagy](https://github.com/ddnexus/pagy) to permit the latest version.
- [Release notes](https://github.com/ddnexus/pagy/releases)
- [Changelog](https://github.com/ddnexus/pagy/blob/master/CHANGELOG.md)
- [Commits](ddnexus/pagy@6.0.0...9.0.5)

---
updated-dependencies:
- dependency-name: pagy
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Pagy has deprecated the size array format and replaced it with an
integer. This is more sensible but doesn't fit in with the GOV.UK Design
System's guidance that says:

> For smaller screens, show page numbers for:
>
> * the current page
> * previous and next pages
> * first and last pages
>
> For larger screens, show page numbers for:
>
> * the current page
> * at least one page immediately before and after the current page
> * first and last pages

The numeric size doesn't provide quite enough control over what's
displayed before/after the current page.

As a result we have to enable the Size Extra[0] functionality, which
allows us to use the old implementation.

Also, Pagy has replaced the items param with limit[1], so the specs have
been updated accordingly.

[0] https://ddnexus.github.io/pagy/docs/extras/size/
[1] https://ddnexus.github.io/pagy/changelog/#version-900
@peteryates peteryates force-pushed the dependabot/bundler/pagy-gte-6-and-lt-10 branch from 26a4a39 to 57465fd Compare August 13, 2024 16:46
@peteryates peteryates added this pull request to the merge queue Aug 13, 2024
Merged via the queue into main with commit 9551f85 Aug 13, 2024
17 checks passed
@peteryates peteryates deleted the dependabot/bundler/pagy-gte-6-and-lt-10 branch August 13, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant