Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pagy requirement from >= 6, < 9 to >= 6, < 10 #548

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Update pagy requirement from >= 6, < 9 to >= 6, < 10 #548

merged 2 commits into from
Aug 13, 2024

Commits on Aug 13, 2024

  1. Update pagy requirement from >= 6, < 9 to >= 6, < 10 

    Updates the requirements on [pagy](https://github.com/ddnexus/pagy) to permit the latest version.
- [Release notes](https://github.com/ddnexus/pagy/releases)
- [Changelog](https://github.com/ddnexus/pagy/blob/master/CHANGELOG.md)
- [Commits](ddnexus/pagy@6.0.0...9.0.5)

---
updated-dependencies:
- dependency-name: pagy
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
    @dependabot @peteryates
    dependabot[bot] authored and peteryates committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    a220959 View commit details
    Browse the repository at this point in the history

  2. Make Pagy use the legacy nav bar 

    Pagy has deprecated the size array format and replaced it with an
integer. This is more sensible but doesn't fit in with the GOV.UK Design
System's guidance that says:

> For smaller screens, show page numbers for:
>
> * the current page
> * previous and next pages
> * first and last pages
>
> For larger screens, show page numbers for:
>
> * the current page
> * at least one page immediately before and after the current page
> * first and last pages

The numeric size doesn't provide quite enough control over what's
displayed before/after the current page.

As a result we have to enable the Size Extra[0] functionality, which
allows us to use the old implementation.

Also, Pagy has replaced the items param with limit[1], so the specs have
been updated accordingly.

[0] https://ddnexus.github.io/pagy/docs/extras/size/
[1] https://ddnexus.github.io/pagy/changelog/#version-900
    @peteryates
    peteryates committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    57465fd View commit details
    Browse the repository at this point in the history