[dotnet/templates/tests] Update template code. (#12109)

* Move the templates to a common subdirectory.
* Add .NET unit test to verify that all the templates build and that they have
  no warnings.
* Modify the template code to:
   * Use the UIApplication.Main overload that takes a Type.
   * Use top-level statements for the Main method to simplify code.
   * Remove a few unnecessary usings.

Partial fix for #12085.

dotnet/Templates/Microsoft.MacCatalyst.Templates/maccatalyst/Main.cs

@@ -0,0 +1,8 @@
+using UIKit;
+
+using MacCatalystApp1;
+
+// This is the main entry point of the application.
+// If you want to use a different Application Delegate class from "AppDelegate"
+// you can specify it here.
+UIApplication.Main (args, null, typeof (AppDelegate));

dotnet/Microsoft.MacCatalyst.Templates/maccatalyst/SceneDelegate.cs → dotnet/Templates/Microsoft.MacCatalyst.Templates/maccatalyst/SceneDelegate.cs

@@ -1,4 +1,3 @@
-using System;
 using Foundation;
 using UIKit;
 

dotnet/Microsoft.iOS.Templates/ios-controller/Controller1.cs → dotnet/Templates/Microsoft.iOS.Templates/ios-controller/Controller1.cs

@@ -1,4 +1,3 @@
-using CoreFoundation;
 using Foundation;
 using UIKit;
 

dotnet/Templates/Microsoft.iOS.Templates/ios/Main.cs

@@ -0,0 +1,8 @@
+using UIKit;
+
+using iOSApp1;
+
+// This is the main entry point of the application.
+// If you want to use a different Application Delegate class from "AppDelegate"
+// you can specify it here.
+UIApplication.Main (args, null, typeof (AppDelegate));

dotnet/Microsoft.iOS.Templates/ios/SceneDelegate.cs → dotnet/Templates/Microsoft.iOS.Templates/ios/SceneDelegate.cs

@@ -1,4 +1,3 @@
-using System;
 using Foundation;
 using UIKit;
 

dotnet/Microsoft.iOS.Templates/ioslib/Class1.cs → dotnet/Templates/Microsoft.iOS.Templates/ioslib/Class1.cs

@@ -1,5 +1,3 @@
-using System;
-
 namespace iOSLib1 {
 	public class Class1 {
 	}

dotnet/Templates/Microsoft.macOS.Templates/macos/Main.cs

@@ -0,0 +1,7 @@
+using AppKit;
+
+using macOSApp1;
+
+// This is the main entry point of the application.
+NSApplication.Init ();
+NSApplication.Main (args);

dotnet/Templates/Microsoft.tvOS.Templates/tvos/Main.cs

@@ -0,0 +1,8 @@
+using UIKit;
+
+using tvOSApp1;
+
+// This is the main entry point of the application.
+// If you want to use a different Application Delegate class from "AppDelegate"
+// you can specify it here.
+UIApplication.Main (args, null, typeof (AppDelegate));

dotnet/Microsoft.tvOS.Templates/tvos/ViewController.cs → dotnet/Templates/Microsoft.tvOS.Templates/tvos/ViewController.cs

@@ -1,5 +1,4 @@
 using System;
-using Foundation;
 using UIKit;
 
 namespace tvOSApp1 {

dotnet/package/microsoft.templates.csproj

@@ -3,7 +3,7 @@
     <PackageId>Microsoft.$(_PlatformName).Templates</PackageId>
     <PackageType>Template</PackageType>
     <Description>Templates for $(_PlatformName) platforms</Description>
-    <_packagePath>$(MSBuildThisFileDirectory)..\Microsoft.$(_PlatformName).Templates\</_packagePath>
+    <_packagePath>$(MSBuildThisFileDirectory)..\Templates\Microsoft.$(_PlatformName).Templates\</_packagePath>
   </PropertyGroup>
   <Import Project="common.csproj" />
 </Project>

tests/common/BinLog.cs

@@ -97,6 +97,11 @@ public static IEnumerable<string> PrintToLines (string path)
 			}
 		}
 
+		public static IEnumerable<BuildLogEvent> GetBuildLogWarnings (string path)
+		{
+			return GetBuildMessages (path).Where (v => v.Type == BuildLogEventType.Warning);
+		}
+
 		public static IEnumerable<BuildLogEvent> GetBuildMessages (string path)
 		{
 			var reader = new BinLogReader ();

tests/common/DotNet.cs

@@ -36,6 +36,31 @@ public static ExecutionResult AssertBuildFailure (string project, Dictionary<str
 			return rv;
 		}
 
+		public static ExecutionResult AssertNew (string outputDirectory, string template)
+		{
+			Directory.CreateDirectory (outputDirectory);
+
+			var args = new List<string> ();
+			args.Add ("new");
+			args.Add (template);
+
+			var env = new Dictionary<string, string> ();
+			env ["MSBuildSDKsPath"] = null;
+			env ["MSBUILD_EXE_PATH"] = null;
+			var output = new StringBuilder ();
+			var rv = Execution.RunWithStringBuildersAsync (Executable, args, env, output, output, Console.Out, workingDirectory: outputDirectory, timeout: TimeSpan.FromMinutes (10)).Result;
+			if (rv.ExitCode != 0) {
+				Console.WriteLine ($"'{Executable} {StringUtils.FormatArguments (args)}' failed with exit code {rv.ExitCode}.");
+				Console.WriteLine (output);
+				Assert.AreEqual (0, rv.ExitCode, $"Exit code: {Executable} {StringUtils.FormatArguments (args)}");
+			}
+			return new ExecutionResult {
+				StandardOutput = output,
+				StandardError = output,
+				ExitCode = rv.ExitCode,
+			};
+		}
+
 		public static ExecutionResult Execute (string verb, string project, Dictionary<string, string> properties, bool assert_success = true)
 		{
 			if (!File.Exists (project))

tests/dotnet/UnitTests/DotNetUnitTests.csproj

@@ -11,6 +11,7 @@
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.2.0" />
     <PackageReference Include="Mono.Cecil" Version="0.11.2" />
     <PackageReference Include="MSBuild.StructuredLogger" Version="2.1.500" />
+    <PackageReference Include="System.Text.Json" Version="5.0.2" />
   </ItemGroup>
 
   <ItemGroup>
@@ -51,4 +52,7 @@
   <ItemGroup>
     <Folder Include="external\" />
   </ItemGroup>
+  <ItemGroup>
+    <None Remove="System.Text.Json" />
+  </ItemGroup>
 </Project>

tests/dotnet/UnitTests/TemplateTest.cs

@@ -0,0 +1,82 @@
+using System;
+using System.Collections.Generic;
+using System.IO;
+using System.Linq;
+using System.Text.Json;
+using System.Text.Json.Serialization;
+
+using NUnit.Framework;
+
+using Xamarin.Utils;
+
+namespace Xamarin.Tests {
+	[TestFixture]
+	public class TemplateTest {
+
+		public static string [][] Templates = {
+			// { platform, template_name }
+			new [] { "iOS", "ios" },
+			new [] { "iOS", "ioslib" },
+			new [] { "tvOS", "tvos" },
+			new [] { "MacCatalyst", "maccatalyst" },
+			new [] { "macOS", "macos" },
+		};
+
+		public class TemplateConfig {
+			public string Name;
+			public string ShortName;
+			public TemplateConfigTag Tags;
+		}
+
+		public class TemplateConfigTag {
+			public string Language;
+			public string Type;
+		}
+
+		[Test]
+		public void AreAllTemplatesListed ()
+		{
+			var allListedTemplates = Templates.Select (v => v [1]).ToArray ();
+			var allTemplates = new List<string> ();
+			foreach (var platform in Enum.GetValues<ApplePlatform> ()) {
+				var dir = Path.Combine (Configuration.SourceRoot, "dotnet", "Templates", $"Microsoft.{platform.AsString ()}.Templates");
+				if (!Directory.Exists (dir))
+					continue;
+
+				var templateDirectories = Directory.GetDirectories (dir);
+				var options = new JsonSerializerOptions {
+					PropertyNameCaseInsensitive = true,
+					IncludeFields = true,
+				};
+
+				// read the template's configuration to figure out if it's a project template, and if not, skip it
+				foreach (var templateDir in templateDirectories) {
+					var jsonPath = Path.Combine (templateDir, ".template.config", "template.json");
+					if (!File.Exists (jsonPath))
+						continue;
+					var json = JsonSerializer.Deserialize<TemplateConfig> (File.ReadAllText (jsonPath), options);
+					if (json.Tags.Type != "project")
+						continue;
+
+					allTemplates.Add (json.ShortName);
+				}
+			}
+			Assert.That (allListedTemplates, Is.EquivalentTo (allTemplates), "The listed templates here and the templates on disk don't match");
+		}
+
+		[Test]
+		[TestCaseSource (nameof (Templates))]
+		public void CreateAndBuildTemplate (string platform, string template)
+		{
+			Configuration.IgnoreIfIgnoredPlatform (platform);
+			var tmpDir = Cache.CreateTemporaryDirectory ();
+			Configuration.CopyDotNetSupportingFiles (tmpDir);
+			var outputDir = Path.Combine (tmpDir, template);
+			DotNet.AssertNew (outputDir, template);
+			var csproj = Path.Combine (outputDir, template + ".csproj");
+			var rv = DotNet.AssertBuild (csproj);
+			var warnings = BinLog.GetBuildLogWarnings (rv.BinLogPath).Select (v => v.Message);
+			Assert.That (warnings, Is.Empty, $"Build warnings:\n\t{string.Join ("\n\t", warnings)}");
+		}
+	}
+}