Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS/Mac project templates use latest C# language idioms #12085

Closed
2 tasks done
Tracked by #3359
mhutch opened this issue Jul 7, 2021 · 2 comments · Fixed by #12197
Closed
2 tasks done
Tracked by #3359

iOS/Mac project templates use latest C# language idioms #12085

mhutch opened this issue Jul 7, 2021 · 2 comments · Fixed by #12197
Assignees
@rolfbjarne
Labels
dotnet An issue or pull request related to .NET (6)
Milestone
.NET 6

Comments

@mhutch
Copy link
Member

mhutch commented Jul 7, 2021 •
edited by rolfbjarne
Loading

In .NET 6, the included C# project templates will use the latest language idioms.

See the parent Epic for details.

Depends on:
@mhutch mhutch mentioned this issue Jul 7, 2021
Closed
12 tasks
@rolfbjarne rolfbjarne added this to the .NET 6 milestone Jul 12, 2021
@rolfbjarne rolfbjarne added the dotnet An issue or pull request related to .NET (6) label Jul 12, 2021
@rolfbjarne rolfbjarne self-assigned this Jul 13, 2021
@rolfbjarne
Copy link
Member

rolfbjarne commented Jul 13, 2021 •
edited
Loading

From the list from the Epic:

rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue Jul 13, 2021
@rolfbjarne
[templates] Update template code.
147593f 
* Use the UIApplication.Main overload that takes a Type.
* Use top-level statements for the Main method to simplify code.
* Remove a few unnecessary usings.

Partial fix for xamarin#12085.
@rolfbjarne rolfbjarne mentioned this issue Jul 13, 2021
Merged
@mhutch
Copy link
Member Author

mhutch commented Jul 13, 2021

Re nulltable types, we need <Nullable>enable</Nullable> in the csproj files created by the templates. The SDK itself is not changing the default value (yet). And we need to verify that nothing in the templates produces nullability warnings.

rolfbjarne added a commit that referenced this issue Jul 14, 2021
@rolfbjarne
[dotnet/templates/tests] Update template code. (#12109)
7ac3417 
* Move the templates to a common subdirectory.
* Add .NET unit test to verify that all the templates build and that they have
  no warnings.
* Modify the template code to:
   * Use the UIApplication.Main overload that takes a Type.
   * Use top-level statements for the Main method to simplify code.
   * Remove a few unnecessary usings.

Partial fix for #12085.
rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue Jul 23, 2021
@rolfbjarne
[dotnet/templates] Use file-scoped namespaces. Fixes xamarin#12085.
b7396d0 
Fixes xamarin#12085.
@rolfbjarne rolfbjarne mentioned this issue Jul 23, 2021
Merged
rolfbjarne added a commit that referenced this issue Jul 23, 2021
@rolfbjarne
[dotnet/templates] Use file-scoped namespaces. Fixes #12085. (#12197)
6c06a9f 
Fixes #12085.
vs-mobiletools-engineering-service2 pushed a commit to vs-mobiletools-engineering-service2/xamarin-macios that referenced this issue Jul 23, 2021
@rolfbjarne
[dotnet/templates] Use file-scoped namespaces. Fixes xamarin#12085.
847a8f9 
Fixes xamarin#12085.
Merged
rolfbjarne added a commit that referenced this issue Jul 27, 2021
@vs-mobiletools-engineering-service2 @rolfbjarne
[dotnet/templates] Use file-scoped namespaces. Fixes #12085. (#12209)
7134624 
Fixes #12085.

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
@ghost ghost locked as resolved and limited conversation to collaborators Apr 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rolfbjarne rolfbjarne

Labels
dotnet An issue or pull request related to .NET (6)
Projects
None yet
Milestone
.NET 6
Development

Successfully merging a pull request may close this issue.

[dotnet/templates] Use file-scoped namespaces. Fixes #12085. rolfbjarne/xamarin-macios
2 participants
@mhutch @rolfbjarne