Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify obsolete selectors to be removed #13621

Closed
rachelkang opened this issue Dec 21, 2021 · 0 comments · Fixed by #14258
Closed

Verify obsolete selectors to be removed #13621

rachelkang opened this issue Dec 21, 2021 · 0 comments · Fixed by #14258
Assignees
@rolfbjarne
Labels
dotnet An issue or pull request related to .NET (6) dotnet-pri0 .NET 6: required for stable release tests Anything related to tests
Milestone
.NET 6

Comments

@rachelkang
Copy link
Contributor

rachelkang commented Dec 21, 2021 •
edited
Loading

This issue addresses the last item on the checklist at #10216.

#13590 adds a cecil test as a starting point for verifying the obsolete selectors to be removed. We will use the switch case in the test to filter the selectors by namespace.

Currently, the test passes by default for all namespaces. Once all the selectors for all namespaces are verified, this should be switched to return false by default, and only return true for namespaces that have been resolved.

Expected Behavior

The test switch case should return false by default. The test should pass not because it returns true, but because all the obsolete selectors have been resolved.

Actual Behavior

Currently, the test passes by default for all namespaces.
@rachelkang rachelkang added the dotnet-pri0 .NET 6: required for stable release label Dec 21, 2021
@rolfbjarne rolfbjarne added this to the .NET 6 milestone Dec 22, 2021
@rolfbjarne rolfbjarne added the tests Anything related to tests label Dec 22, 2021
@rolfbjarne rolfbjarne mentioned this issue Feb 3, 2022
Closed
44 tasks
@rolfbjarne rolfbjarne self-assigned this Feb 15, 2022
@rolfbjarne rolfbjarne added the dotnet An issue or pull request related to .NET (6) label Feb 15, 2022
rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue Feb 25, 2022
@rolfbjarne
[cecil-tests] Improve the obsolete member test. Fixes xamarin#13621.
74f7d79 
* Check implementation assemblies instead of reference assemblies.
* Try to print the source code location for failing API (this required processing
  the implementation assemblies, because the reference assemblies don't have debug
  information where the source code location is stored).
* Don't report API that has [EditorBrowsable (None)] attributes, presumably we
  decided to keep these for compatibility, while highly discouraging their
  continued use. Also stop doing this for the next time we can do a breaking
  change, maybe we can remove these APIs then.
* Don't report API that has [UnsupportedOSPlatform ("...#.#") attributes (with
  a version number), presumably this is API that is still valid for some OS
  versions.
* Enable the test for all APIs (no ignores anymore). It's green!

Fixes xamarin#13621.
@rolfbjarne rolfbjarne mentioned this issue Feb 25, 2022
Merged
rolfbjarne added a commit that referenced this issue Feb 28, 2022
@rolfbjarne
[cecil-tests] Improve the obsolete member test. Fixes #13621. (#14258)
df491ed 
* Check implementation assemblies instead of reference assemblies.
* Try to print the source code location for failing API (this required processing
  the implementation assemblies, because the reference assemblies don't have debug
  information where the source code location is stored).
* Don't report API that has [EditorBrowsable (None)] attributes, presumably we
  decided to keep these for compatibility, while highly discouraging their
  continued use. Also stop doing this for the next time we can do a breaking
  change, maybe we can remove these APIs then.
* Don't report API that has [UnsupportedOSPlatform ("...#.#") attributes (with
  a version number), presumably this is API that is still valid for some OS
  versions.
* Enable the test for all APIs (no ignores anymore). It's green!

Fixes #13621.
tj-devel709 pushed a commit to tj-devel709/xamarin-macios that referenced this issue Mar 8, 2022
@rolfbjarne
[cecil-tests] Improve the obsolete member test. Fixes xamarin#13621. (x…
69f1ad2 
…amarin#14258)

* Check implementation assemblies instead of reference assemblies.
* Try to print the source code location for failing API (this required processing
  the implementation assemblies, because the reference assemblies don't have debug
  information where the source code location is stored).
* Don't report API that has [EditorBrowsable (None)] attributes, presumably we
  decided to keep these for compatibility, while highly discouraging their
  continued use. Also stop doing this for the next time we can do a breaking
  change, maybe we can remove these APIs then.
* Don't report API that has [UnsupportedOSPlatform ("...#.#") attributes (with
  a version number), presumably this is API that is still valid for some OS
  versions.
* Enable the test for all APIs (no ignores anymore). It's green!

Fixes xamarin#13621.
@ghost ghost locked as resolved and limited conversation to collaborators Apr 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rolfbjarne rolfbjarne

Labels
dotnet An issue or pull request related to .NET (6) dotnet-pri0 .NET 6: required for stable release tests Anything related to tests
Projects
None yet
Milestone
.NET 6
Development

Successfully merging a pull request may close this issue.

[cecil-tests] Improve the obsolete member test. Fixes #13621. rolfbjarne/xamarin-macios
2 participants
@rolfbjarne @rachelkang