Add cecil test for verifying obsoleted apis #13590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chamons
approved these changes
Dec 16, 2021
tests/cecil-tests/ObsoleteTest.cs
Outdated
| var assembly = Helper.GetAssembly (assemblyPath); | ||
| if (assembly == null) { | ||
| Assert.Ignore ("{assemblyPath} could not be found (might be disabled in build)"); | ||
| return; // just to help nullability |
There was a problem hiding this comment.
Suggested change
| return; // just to help nullability | |
| return; |
tests/cecil-tests/ObsoleteTest.cs
Outdated
|
|
||
| // TODO: Events? | ||
|
|
||
| Console.WriteLine (found.Count); |
There was a problem hiding this comment.
This CWL was a debugging aid on the sample I pointed you to. I think it can be removed.
tests/cecil-tests/ObsoleteTest.cs
Outdated
|
|
||
| bool HasObsoleteAttribute (IEnumerable<CustomAttribute> attributes) => attributes.Any (a => IsObsoleteAttribute (a)); | ||
|
|
||
| bool IsObsoleteAttribute (CustomAttribute attribute) |
There was a problem hiding this comment.
Maybe a 1 liner here?
bool IsObsoleteAttribute (CustomAttribute attribute) => attribute.AttributeType.Name == "Obsolete" ||
attribute.AttributeType.Name == "ObsoleteAttribute";
rolfbjarne
requested changes
Dec 16, 2021
tests/cecil-tests/ObsoleteTest.cs
Outdated
| Assert.Ignore ("{assemblyPath} could not be found (might be disabled in build)"); | ||
| return; | ||
| } | ||
| Console.WriteLine(assemblyPath); |
There was a problem hiding this comment.
Suggested change
| Console.WriteLine(assemblyPath); | |
| Console.WriteLine (assemblyPath); |
mandel-macaque
approved these changes
Dec 17, 2021
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View dotnet API diffView dotnet legacy API diffAPI Current PR diffℹ️ API Diff (from PR only) (please review changes) View dotnet API diffView dotnet legacy API diffGenerator diff✅ Generator Diff (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results3 tests failed, 166 tests passed.Failed tests
Pipeline on Agent XAMBOT-1101.BigSur' |
tj-devel709
reviewed
Dec 17, 2021
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View dotnet API diffView dotnet legacy API diffAPI Current PR diffℹ️ API Diff (from PR only) (please review changes) View dotnet API diffView dotnet legacy API diffGenerator diff✅ Generator Diff (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results11 tests failed, 158 tests passed.Failed tests
Pipeline on Agent XAMBOT-1094.BigSur' |
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View dotnet API diffView dotnet legacy API diffAPI Current PR diffℹ️ API Diff (from PR only) (please review changes) View dotnet API diffView dotnet legacy API diffGenerator diff✅ Generator Diff (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results3 tests failed, 166 tests passed.Failed tests
Pipeline on Agent XAMBOT-1101.BigSur' |
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View dotnet API diffView dotnet legacy API diffAPI Current PR diffℹ️ API Diff (from PR only) (please review changes) View dotnet API diffView dotnet legacy API diffGenerator diff✅ Generator Diff (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results1 tests failed, 168 tests passed.Failed tests
Pipeline on Agent XAMBOT-1097.BigSur' |
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View dotnet API diffView dotnet legacy API diffAPI Current PR diffℹ️ API Diff (from PR only) (please review changes) View dotnet API diffView dotnet legacy API diffGenerator diff✅ Generator Diff (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results3 tests failed, 166 tests passed.Failed tests
Pipeline on Agent XAMBOT-1094.BigSur' |
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View dotnet API diffView dotnet legacy API diffAPI Current PR diffℹ️ API Diff (from PR only) (please review changes) View dotnet API diffView dotnet legacy API diffGenerator diff✅ Generator Diff (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results2 tests failed, 167 tests passed.Failed tests
Pipeline on Agent XAMBOT-1094.BigSur' |
dalexsoto
approved these changes
Jan 6, 2022
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View dotnet API diffView dotnet legacy API diffAPI Current PR diffℹ️ API Diff (from PR only) (please review changes) View dotnet API diffView dotnet legacy API diffGenerator diff✅ Generator Diff (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results1 tests failed, 168 tests passed.Failed tests
Pipeline on Agent XAMBOT-1101.BigSur' |
|
bgen-tests are no longer failing! Thank you @chamons for all the help. Remaining failing test is unrelated: https://github.com/xamarin/maccore/issues/2414 |
rolfbjarne
requested changes
Jan 10, 2022
rolfbjarne
approved these changes
Jan 11, 2022
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View dotnet API diffView dotnet legacy API diffAPI Current PR diffℹ️ API Diff (from PR only) (please review changes) View dotnet API diffView dotnet legacy API diffGenerator diff✅ Generator Diff (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results1 tests failed, 168 tests passed.Failed tests
Pipeline on Agent XAMBOT-1104.BigSur' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrote a cecil test for verifying obsolete properties, methods, and types.
Included a switch statement to filter by namespace as work progresses.
Largely collaborated with @chamons and inspired by his AttributeTest