[iTunesLibrary] Update bindings for Xcode 13.0 beta 1 #12038

rachelkang · 2021-06-29T14:48:10Z

No description provided.

rolfbjarne · 2021-06-29T14:54:05Z

src/ituneslibrary.cs

+ [Export ("master")]
+ bool Master { [Bind ("isMaster")] get; }


I see that you've moved the Master declaration here from above - but don't move code around unless really necessary, because it shows up as "removed+added" in the diff, which makes the diff harder to review.

On a more general note, changes that don't really change anything also makes it harder to run "git blame" to figure out when/what something happened, because the first thing that will come up is the commit that moved the code, which is not what you're looking for.

To add to that, if we where working with a xcode13 branch, it would make my life harder when doing merges and back ports :/

understood! fixed :)

mandel-macaque

Approving once the master move is undone.

…marin-macios into xcode13.0-iTunesLibrary-b1

rolfbjarne

👍

vs-mobiletools-engineering-service2 · 2021-06-29T19:53:07Z

✅ [PR Build] Tests passed on Build. ✅

Tests passed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

🎉 All 86 tests passed 🎉

Pipeline on Agent XAMBOT-1096.BigSur'
Merge 009f45d into a64b030

dalexsoto

After these two nits

dalexsoto · 2021-06-29T20:53:12Z

src/ituneslibrary.cs

@@ -307,9 +307,15 @@ interface ITLibPlaylist
 [Export ("name")]
 string Name { get; }

+ [Introduced (PlatformName.MacOSX, 10, 6, message: "Use 'isPrimary' instead.")]


Suggested change

[Introduced (PlatformName.MacOSX, 10, 6, message: "Use 'isPrimary' instead.")]

[Introduced (PlatformName.MacOSX, 10, 6, message: "Use 'Primary' instead.")]

dalexsoto · 2021-06-29T20:53:22Z

src/ituneslibrary.cs

@@ -307,9 +307,15 @@ interface ITLibPlaylist
 [Export ("name")]
 string Name { get; }

+ [Introduced (PlatformName.MacOSX, 10, 6, message: "Use 'isPrimary' instead.")]
+ [Deprecated (PlatformName.MacOSX, 12, 0, message: "Use 'isPrimary' instead.")]


Suggested change

[Deprecated (PlatformName.MacOSX, 12, 0, message: "Use 'isPrimary' instead.")]

[Deprecated (PlatformName.MacOSX, 12, 0, message: "Use 'Primary' instead.")]

dalexsoto · 2021-06-29T20:55:01Z

We use the .NET name in the message strings, this is the reason behind the change isPrimary to Primary

dalexsoto · 2021-06-30T13:53:06Z

src/iTunesLibrary/Enums.cs

+ [Introduced (PlatformName.MacOSX, 10, 6, message: "Use 'ITLibPlaylistPropertyPrimary' instead.")]
+ [Deprecated (PlatformName.MacOSX, 12, 0, message: "Use 'ITLibPlaylistPropertyPrimary' instead.")]


This one is also not needed

Suggested change

[Introduced (PlatformName.MacOSX, 10, 6, message: "Use 'ITLibPlaylistPropertyPrimary' instead.")]

[Deprecated (PlatformName.MacOSX, 12, 0, message: "Use 'ITLibPlaylistPropertyPrimary' instead.")]

[Deprecated (PlatformName.MacOSX, 12, 0, message: "Use 'Primary' instead.")]

rachelkang · 2021-06-30T17:34:28Z

intro and xtro are all green!

vs-mobiletools-engineering-service2 · 2021-06-30T20:44:58Z

✅ [PR Build] Tests passed on Build. ✅

Tests passed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

🎉 All 86 tests passed 🎉

Pipeline on Agent XAMBOT-1094.BigSur'
Merge 9da7629 into 0bfb745

tj-devel709 · 2021-07-06T16:20:23Z

This one looks good to "Squash and merge"!

vs-mobiletools-engineering-service2 · 2021-07-06T21:24:32Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 85 tests passed.

Failed tests

monotouch-test/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 2622 Passed: 2489 Inconclusive: 35 Failed: 1 Ignored: 132)

Pipeline on Agent XAMBOT-1100.BigSur'
Merge 3112f6d into 3b6f059

rachelkang · 2021-07-07T18:23:33Z

Test failure unrelated - https://github.com/xamarin/maccore/issues/2443

vs-mobiletools-engineering-service2 · 2021-07-07T22:52:12Z

✅ [PR Build] Tests passed on Build. ✅

Tests passed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

🎉 All 86 tests passed 🎉

Pipeline on Agent XAMBOT-1098.BigSur'
Merge 24673ce into f963938

vs-mobiletools-engineering-service2 · 2021-07-08T21:19:21Z

✅ [PR Build] Tests passed on Build. ✅

Tests passed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

🎉 All 86 tests passed 🎉

Pipeline on Agent XAMBOT-1096.BigSur'
Merge 7f6c94f into ac5c157

[iTunesLibrary] Update bindings for Xcode 13.0 beta 1

80cf395

rachelkang added the note-highlight Worth calling out specifically in release notes label Jun 29, 2021

rachelkang added this to the xcode13.0 milestone Jun 29, 2021

rachelkang requested review from dalexsoto, rolfbjarne, spouliot and mandel-macaque June 29, 2021 14:48

Merge branch 'main' into xcode13.0-iTunesLibrary-b1

62340a0

rolfbjarne requested changes Jun 29, 2021

View reviewed changes

mandel-macaque approved these changes Jun 29, 2021

View reviewed changes

rachelkang added 2 commits June 29, 2021 11:41

Move existing property back to original location

5bbbcf7

Merge branch 'xcode13.0-iTunesLibrary-b1' of github.com:rachelkang/xa…

009f45d

…marin-macios into xcode13.0-iTunesLibrary-b1

rolfbjarne approved these changes Jun 29, 2021

View reviewed changes

tj-devel709 approved these changes Jun 29, 2021

View reviewed changes

dalexsoto approved these changes Jun 29, 2021

View reviewed changes

dalexsoto reviewed Jun 30, 2021

View reviewed changes

rachelkang added 3 commits June 30, 2021 10:52

Merge branch 'main' into xcode13.0-iTunesLibrary-b1

20fdc70

Fix message and remove unnecessary Introduced tags

9c7f682

Fix typo in deprecation message

9da7629

Merge branch 'main' into xcode13.0-iTunesLibrary-b1

3112f6d

Merge branch 'main' into xcode13.0-iTunesLibrary-b1

24673ce

Delete empty .todo file

7f6c94f

tj-devel709 merged commit 924c006 into xamarin:main Jul 9, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[iTunesLibrary] Update bindings for Xcode 13.0 beta 1 #12038

[iTunesLibrary] Update bindings for Xcode 13.0 beta 1 #12038

rachelkang commented Jun 29, 2021

rolfbjarne Jun 29, 2021

mandel-macaque Jun 29, 2021

rachelkang Jun 29, 2021

mandel-macaque left a comment

rolfbjarne left a comment

vs-mobiletools-engineering-service2 commented Jun 29, 2021

dalexsoto left a comment

dalexsoto Jun 29, 2021

dalexsoto Jun 29, 2021

dalexsoto commented Jun 29, 2021

dalexsoto Jun 30, 2021 •

edited

Loading

rachelkang commented Jun 30, 2021

vs-mobiletools-engineering-service2 commented Jun 30, 2021

tj-devel709 commented Jul 6, 2021

vs-mobiletools-engineering-service2 commented Jul 6, 2021

Failed tests

rachelkang commented Jul 7, 2021

vs-mobiletools-engineering-service2 commented Jul 7, 2021

vs-mobiletools-engineering-service2 commented Jul 8, 2021

	[Introduced (PlatformName.MacOSX, 10, 6, message: "Use 'isPrimary' instead.")]
	[Introduced (PlatformName.MacOSX, 10, 6, message: "Use 'Primary' instead.")]

	[Deprecated (PlatformName.MacOSX, 12, 0, message: "Use 'isPrimary' instead.")]
	[Deprecated (PlatformName.MacOSX, 12, 0, message: "Use 'Primary' instead.")]

[iTunesLibrary] Update bindings for Xcode 13.0 beta 1 #12038

[iTunesLibrary] Update bindings for Xcode 13.0 beta 1 #12038

Conversation

rachelkang commented Jun 29, 2021

rolfbjarne Jun 29, 2021

Choose a reason for hiding this comment

mandel-macaque Jun 29, 2021

Choose a reason for hiding this comment

rachelkang Jun 29, 2021

Choose a reason for hiding this comment

mandel-macaque left a comment

Choose a reason for hiding this comment

rolfbjarne left a comment

Choose a reason for hiding this comment

vs-mobiletools-engineering-service2 commented Jun 29, 2021

✅ [PR Build] Tests passed on Build. ✅

API diff

API & Generator diff

GitHub pages

🎉 All 86 tests passed 🎉

dalexsoto left a comment

Choose a reason for hiding this comment

dalexsoto Jun 29, 2021

Choose a reason for hiding this comment

dalexsoto Jun 29, 2021

Choose a reason for hiding this comment

dalexsoto commented Jun 29, 2021

dalexsoto Jun 30, 2021 • edited Loading

Choose a reason for hiding this comment

rachelkang commented Jun 30, 2021

vs-mobiletools-engineering-service2 commented Jun 30, 2021

✅ [PR Build] Tests passed on Build. ✅

API diff

API & Generator diff

GitHub pages

🎉 All 86 tests passed 🎉

tj-devel709 commented Jul 6, 2021

vs-mobiletools-engineering-service2 commented Jul 6, 2021

❌ [PR Build] Tests failed on Build ❌

API diff

API & Generator diff

GitHub pages

Test results

Failed tests

rachelkang commented Jul 7, 2021

vs-mobiletools-engineering-service2 commented Jul 7, 2021

✅ [PR Build] Tests passed on Build. ✅

API diff

API & Generator diff

GitHub pages

🎉 All 86 tests passed 🎉

vs-mobiletools-engineering-service2 commented Jul 8, 2021

✅ [PR Build] Tests passed on Build. ✅

API diff

API & Generator diff

GitHub pages

🎉 All 86 tests passed 🎉

dalexsoto Jun 30, 2021 •

edited

Loading