Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iTunesLibrary] Update bindings for Xcode 13.0 beta 1 #12038

Merged
merged 10 commits into from
Jul 9, 2021
Merged

[iTunesLibrary] Update bindings for Xcode 13.0 beta 1 #12038

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
80cf395
[iTunesLibrary] Update bindings for Xcode 13.0 beta 1
rachelkang Jun 29, 2021
62340a0
Merge branch 'main' into xcode13.0-iTunesLibrary-b1
rachelkang Jun 29, 2021
5bbbcf7
Move existing property back to original location
rachelkang Jun 29, 2021
009f45d
Merge branch 'xcode13.0-iTunesLibrary-b1' of github.com:rachelkang/xa…
rachelkang Jun 29, 2021
20fdc70
Merge branch 'main' into xcode13.0-iTunesLibrary-b1
rachelkang Jun 30, 2021
9c7f682
Fix message and remove unnecessary Introduced tags
rachelkang Jun 30, 2021
9da7629
Fix typo in deprecation message
rachelkang Jun 30, 2021
3112f6d
Merge branch 'main' into xcode13.0-iTunesLibrary-b1
rachelkang Jul 6, 2021
24673ce
Merge branch 'main' into xcode13.0-iTunesLibrary-b1
rachelkang Jul 7, 2021
7f6c94f
Delete empty .todo file
rachelkang Jul 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/iTunesLibrary/Enums.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,10 +301,15 @@ public enum ITLibPlaylistProperty {
AllItemsPlaylist,
[Field ("ITLibPlaylistPropertyDistinguisedKind")]
DistinguisedKind,
[Introduced (PlatformName.MacOSX, 10, 6, message: "Use 'ITLibPlaylistPropertyPrimary' instead.")]
[Deprecated (PlatformName.MacOSX, 12, 0, message: "Use 'ITLibPlaylistPropertyPrimary' instead.")]
Copy link
Member

@dalexsoto dalexsoto Jun 30, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is also not needed

Suggested change
[Introduced (PlatformName.MacOSX, 10, 6, message: "Use 'ITLibPlaylistPropertyPrimary' instead.")]
[Deprecated (PlatformName.MacOSX, 12, 0, message: "Use 'ITLibPlaylistPropertyPrimary' instead.")]
[Deprecated (PlatformName.MacOSX, 12, 0, message: "Use 'Primary' instead.")]

[Field ("ITLibPlaylistPropertyMaster")]
Master,
[Field ("ITLibPlaylistPropertyParentPersistentID")]
ParentPersistentId,
[Mac (12, 0)]
[Field ("ITLibPlaylistPropertyPrimary")]
Primary,
[Field ("ITLibPlaylistPropertyVisible")]
Visible,
[Field ("ITLibPlaylistPropertyItems")]
Expand All @@ -318,4 +323,4 @@ public enum ITLibMediaEntityProperty {
[Field ("ITLibMediaEntityPropertyPersistentID")]
PersistentId,
}
}
}
8 changes: 7 additions & 1 deletion src/ituneslibrary.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,9 +307,15 @@ interface ITLibPlaylist
[Export ("name")]
string Name { get; }

[Introduced (PlatformName.MacOSX, 10, 6, message: "Use 'isPrimary' instead.")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[Introduced (PlatformName.MacOSX, 10, 6, message: "Use 'isPrimary' instead.")]
[Introduced (PlatformName.MacOSX, 10, 6, message: "Use 'Primary' instead.")]

[Deprecated (PlatformName.MacOSX, 12, 0, message: "Use 'isPrimary' instead.")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[Deprecated (PlatformName.MacOSX, 12, 0, message: "Use 'isPrimary' instead.")]
[Deprecated (PlatformName.MacOSX, 12, 0, message: "Use 'Primary' instead.")]

[Export ("master")]
bool Master { [Bind ("isMaster")] get; }

[Mac (12,0)]
[Export ("primary")]
bool Primary { [Bind ("isPrimary")] get; }

[NullAllowed, Export ("parentID", ArgumentSemantic.Retain)]
NSNumber ParentId { get; }

Expand Down Expand Up @@ -389,4 +395,4 @@ interface ITLibrary
void UnloadData ();
}

}
}
3 changes: 0 additions & 3 deletions tests/xtro-sharpie/macOS-iTunesLibrary.todo
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +0,0 @@
!deprecated-attribute-missing! ITLibPlaylist::isMaster missing a [Deprecated] attribute
!missing-field! ITLibPlaylistPropertyPrimary not bound
!missing-selector! ITLibPlaylist::isPrimary not bound