Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UserNotifications] Updates for Xcode13 beta 3 #12130

Merged
merged 13 commits into from
Jul 23, 2021
Merged

[UserNotifications] Updates for Xcode13 beta 3 #12130

merged 13 commits into from
Jul 23, 2021

Conversation

tj-devel709
Copy link
Contributor

No description provided.

@tj-devel709 tj-devel709 added the note-highlight Worth calling out specifically in release notes label Jul 15, 2021
@tj-devel709 tj-devel709 added this to the xcode13.0 milestone Jul 15, 2021
@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 85 tests passed.

Failed tests

  • introspection/tvOS - simulator/Debug (tvOS 11.4): Failed

Pipeline on Agent XAMBOT-1104.BigSur'
Merge 386fd40 into dacf374

rolfbjarne
rolfbjarne approved these changes Jul 16, 2021
View reviewed changes
src/usernotifications.cs Outdated Show resolved Hide resolved
src/usernotifications.cs Outdated Show resolved Hide resolved
mandel-macaque
mandel-macaque approved these changes Jul 16, 2021
View reviewed changes
Copy link
Member

@mandel-macaque mandel-macaque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, please address the two comments from rolf AND update the WIKI with the PR!

src/usernotifications.cs Outdated Show resolved Hide resolved
@mandel-macaque mandel-macaque added the do-not-merge Do not merge this pull request label Jul 16, 2021
@mandel-macaque
Copy link
Member

DO NOT MERGE, changes are coming with xcode13 beta 3 :/

spouliot
spouliot suggested changes Jul 19, 2021
View reviewed changes
src/usernotifications.cs Outdated Show resolved Hide resolved
src/usernotifications.cs Outdated Show resolved Hide resolved
src/usernotifications.cs Outdated Show resolved Hide resolved
src/usernotifications.cs Outdated Show resolved Hide resolved
src/usernotifications.cs Outdated Show resolved Hide resolved
src/usernotifications.cs Outdated Show resolved Hide resolved
src/usernotifications.cs Outdated Show resolved Hide resolved
src/usernotifications.cs Outdated Show resolved Hide resolved
tests/xtro-sharpie/tvOS-UserNotifications.ignore Show resolved Hide resolved
tests/xtro-sharpie/watchOS-UserNotifications.ignore Show resolved Hide resolved
spouliot
spouliot approved these changes Jul 19, 2021
View reviewed changes
Copy link
Contributor

@spouliot spouliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't forget to update the PR title to beta 3 before merging

mandel-macaque
mandel-macaque requested changes Jul 19, 2021
View reviewed changes
tests/xtro-sharpie/watchOS-UserNotifications.ignore
@@ -0,0 +1,7 @@
# both added and deprecated in Xcode 13 beta 2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tj-devel709 do we get these errors when using beta 3? Have you tried removing it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I remove this, I get errors still!

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

2 tests failed, 84 tests passed.

Failed tests

  • monotouch-test/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 2629 Passed: 2493 Inconclusive: 35 Failed: 1 Ignored: 135)
  • introspection/tvOS - simulator/Debug (tvOS 11.4): Failed

Pipeline on Agent XAMBOT-1099.BigSur'
Merge 09b686f into e968a93

@mandel-macaque mandel-macaque removed the do-not-merge Do not merge this pull request label Jul 20, 2021
@tj-devel709 tj-devel709 changed the title [UserNotifications] Updates for Xcode13 beta 2 [UserNotifications] Updates for Xcode13 beta 3 Jul 20, 2021
@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 85 tests passed.

Failed tests

  • introspection/tvOS - simulator/Debug (tvOS 11.4): Failed

Pipeline on Agent XAMBOT-1103.BigSur'
Merge 9306dc7 into eea8142

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 88 tests passed.

Failed tests

  • monotouch-test/tvOS - simulator/Debug: Failed

Pipeline on Agent XAMBOT-1100.BigSur'
Merge ac699ab into de7f08d

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

2 tests failed, 87 tests passed.

Failed tests

  • monotouch-test/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 2629 Passed: 2490 Inconclusive: 35 Failed: 3 Ignored: 136)
  • link sdk/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 129 Passed: 105 Inconclusive: 6 Failed: 1 Ignored: 23)

Pipeline on Agent XAMBOT-1108.BigSur'
Merge 76e9e24 into 4060387

@tj-devel709
Copy link
Contributor Author

Updating to fix this unrelated issue: https://github.com/xamarin/maccore/issues/2472

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 88 tests passed.

Failed tests

  • monotouch-test/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 2629 Passed: 2485 Inconclusive: 35 Failed: 3 Ignored: 141)

Pipeline on Agent XAMBOT-1100.BigSur'
Merge beacba0 into 28bb8bc

@tj-devel709
Copy link
Contributor Author

Failing unrelated tests: https://github.com/xamarin/maccore/issues/2443 and
https://github.com/xamarin/maccore/issues/2471

@tj-devel709 tj-devel709 merged commit a27a58a into xamarin:main Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolfbjarne rolfbjarne rolfbjarne approved these changes

@spouliot spouliot spouliot approved these changes

@mandel-macaque mandel-macaque mandel-macaque approved these changes

@dalexsoto dalexsoto Awaiting requested review from dalexsoto dalexsoto is a code owner

Assignees
No one assigned
Labels
note-highlight Worth calling out specifically in release notes
Projects
None yet
Milestone
xcode13.0
Development

Successfully merging this pull request may close these issues.
5 participants
@tj-devel709 @vs-mobiletools-engineering-service2 @mandel-macaque @rolfbjarne @spouliot