Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SoundAnalysis] Updates for Xcode13 Beta1 #12181

Merged

Conversation

tj-devel709
Copy link
Contributor

No description provided.

@tj-devel709 tj-devel709 added the note-highlight Worth calling out specifically in release notes label Jul 22, 2021
@tj-devel709 tj-devel709 added this to the xcode13.0 milestone Jul 22, 2021
@tj-devel709 tj-devel709 requested a review from spouliot as a code owner July 22, 2021 18:38
src/soundanalysis.cs Show resolved Hide resolved
src/soundanalysis.cs Outdated Show resolved Hide resolved
src/soundanalysis.cs Show resolved Hide resolved
interface SNTimeDurationConstraint /* privately conforms to NSCoding, NSCopying, and NSSecureCoding */
{
[Export ("initWithEnumeratedDurations:")]
IntPtr Constructor (NSValue[] enumeratedDurations);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@param enumeratedDurations A discrete set of duration values (represented as CMTime values boxed in NSValue instances) permitted by this constraint.

Have you tried [BindAs] ? not sure if it handle this case...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I tried this and showed @dalexsoto and he came to the conclusion that CMTime arrays are not supported yet

SNTimeDurationConstraintType Type { get; }

[Export ("enumeratedDurations", ArgumentSemantic.Strong)]
NSValue[] EnumeratedDurations { get; }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

2 tests failed, 87 tests passed.

Failed tests

  • monotouch-test/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 2629 Passed: 2491 Inconclusive: 35 Failed: 2 Ignored: 136)
  • link sdk/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 129 Passed: 105 Inconclusive: 6 Failed: 1 Ignored: 23)

Pipeline on Agent XAMBOT-1105.BigSur'
Merge 0e4cdba into 4060387

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 88 tests passed.

Failed tests

  • monotouch-test/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 2629 Passed: 2485 Inconclusive: 35 Failed: 3 Ignored: 141)

Pipeline on Agent XAMBOT-1098.BigSur'
Merge 9699dab into 24acd2d

@tj-devel709 tj-devel709 added the do-not-merge Do not merge this pull request label Jul 26, 2021
@mandel-macaque mandel-macaque removed the do-not-merge Do not merge this pull request label Aug 3, 2021
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build] Tests passed on Build. ✅

Tests passed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

🎉 All 90 tests passed 🎉

Pipeline on Agent XAMBOT-1105.BigSur'
Merge 486beff into fda13f2

@mandel-macaque mandel-macaque merged commit 9a6c075 into xamarin:main Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
note-highlight Worth calling out specifically in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants