Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Foundation] Enabling CoreMedia in Watch #12280

Merged
merged 2 commits into from
Jul 30, 2021
Merged

[Foundation] Enabling CoreMedia in Watch #12280

merged 2 commits into from
Jul 30, 2021

Conversation

tj-devel709
Copy link
Contributor

CoreMedia looks like it has been supported since watchOS 6 so I am enabling it now as mentioned here!

@tj-devel709 tj-devel709 added the not-notes-worthy Ignore for release notes label Jul 28, 2021
@tj-devel709 tj-devel709 added this to the Future milestone Jul 28, 2021
@tj-devel709 tj-devel709 mentioned this pull request Jul 28, 2021
Merged
spouliot
spouliot approved these changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@spouliot spouliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

7 tests failed, 82 tests passed.

Failed tests

  • xammac tests/Mac Modern/Debug: Failed (Test run failed.
    Tests run: 2463 Passed: 2407 Inconclusive: 10 Failed: 1 Ignored: 55)
  • xammac tests/Mac Modern/Release: Failed (Test run failed.
    Tests run: 2460 Passed: 2403 Inconclusive: 10 Failed: 1 Ignored: 56)
  • xammac tests/Mac Modern/Release (all optimizations): Failed (Test run failed.
    Tests run: 2460 Passed: 2402 Inconclusive: 10 Failed: 1 Ignored: 57)
  • monotouch-test/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 2629 Passed: 2490 Inconclusive: 35 Failed: 1 Ignored: 138)
  • monotouch-test/iOS Unified 64-bits - simulator/Debug: Failed
  • monotouch-test/iOS Unified 64-bits - simulator/Debug (LinkSdk): Failed
  • monotouch-test/iOS Unified 64-bits - simulator/Debug (static registrar): Failed

Pipeline on Agent XAMBOT-1098.BigSur'
Merge ec047a4 into 448cc6e

@mandel-macaque
Copy link
Member

Unrelated failures:

@mandel-macaque mandel-macaque merged commit a4ca843 into xamarin:main Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandel-macaque mandel-macaque mandel-macaque approved these changes

@spouliot spouliot spouliot approved these changes

@rolfbjarne rolfbjarne rolfbjarne approved these changes

@dalexsoto dalexsoto dalexsoto approved these changes

Assignees
No one assigned
Labels
not-notes-worthy Ignore for release notes
Projects
None yet
Milestone
Future
Development

Successfully merging this pull request may close these issues.
6 participants
@tj-devel709 @vs-mobiletools-engineering-service2 @mandel-macaque @dalexsoto @rolfbjarne @spouliot