Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SensorKit] Updates for Xcode13 Beta1 #12188

Merged
merged 2 commits into from
Jul 23, 2021
Merged

[SensorKit] Updates for Xcode13 Beta1 #12188

merged 2 commits into from
Jul 23, 2021

Conversation

tj-devel709
Copy link
Contributor

No description provided.

@tj-devel709 tj-devel709 added the note-highlight Worth calling out specifically in release notes label Jul 22, 2021
@tj-devel709 tj-devel709 added this to the xcode13.0 milestone Jul 22, 2021
@tj-devel709 tj-devel709 requested a review from spouliot as a code owner July 22, 2021 22:50
@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

2 tests failed, 87 tests passed.

Failed tests

  • monotouch-test/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 2629 Passed: 2490 Inconclusive: 35 Failed: 3 Ignored: 136)
  • link sdk/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 129 Passed: 105 Inconclusive: 6 Failed: 1 Ignored: 23)

Pipeline on Agent XAMBOT-1100.BigSur'
Merge 7458807 into 7dd7960

rolfbjarne
rolfbjarne approved these changes Jul 23, 2021
View reviewed changes
src/sensorkit.cs
{
Absolutist,
Down,
Death,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a rather depressing enum...

@tj-devel709
Copy link
Contributor Author

Updating to fix this unrelated issue: https://github.com/xamarin/maccore/issues/2472

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 88 tests passed.

Failed tests

  • monotouch-test/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 2629 Passed: 2486 Inconclusive: 35 Failed: 2 Ignored: 141)

Pipeline on Agent XAMBOT-1094.BigSur'
Merge 9b426e4 into 28bb8bc

@tj-devel709
Copy link
Contributor Author

Failing unrelated tests: https://github.com/xamarin/maccore/issues/2471

@tj-devel709 tj-devel709 merged commit 62a9fd9 into xamarin:main Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandel-macaque mandel-macaque mandel-macaque approved these changes

@spouliot spouliot spouliot approved these changes

@rolfbjarne rolfbjarne rolfbjarne approved these changes

Assignees
No one assigned
Labels
note-highlight Worth calling out specifically in release notes
Projects
None yet
Milestone
xcode13.0
Development

Successfully merging this pull request may close these issues.
5 participants
@tj-devel709 @vs-mobiletools-engineering-service2 @rolfbjarne @spouliot @mandel-macaque