[ModelIO] Add Xcode 13 beta4 support. #12349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mandel-macaque
added
the
note-highlight
spouliot
approved these changes
Aug 4, 2021
src/modelio.cs
Outdated
| [Deprecated (PlatformName.iOS, 15, 0, message: "Use the 'Originals' instead.")] | ||
| [Deprecated (PlatformName.TvOS, 15, 0, message: "Use the 'Originals' instead.")] | ||
| [Deprecated (PlatformName.MacOSX, 12, 0, message: "Use the 'Originals' instead.")] | ||
| [Deprecated (PlatformName.MacCatalyst, 15, 0, message: "Use the 'Originals' instead.")] |
There was a problem hiding this comment.
sounds weird - "Use 'Originals' instead." or "Use the 'Originals' property instead."
There was a problem hiding this comment.
I can change it to the 'property' one
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results1 tests failed, 89 tests passed.Failed tests
Pipeline on Agent XAMBOT-1097.BigSur' |
|
Unrelated issue: https://github.com/xamarin/maccore/issues/2414 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.