-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QuickLookUI] Update bindings for Xcode 13.0 beta 1 #12389
Merged
Merged
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
88392b8
[QuickLookUI] Update bindings for Xcode 13.0 beta 1
rachelkang 80de25c
Add missing using and remove todo
rachelkang d27fdac
update based on feedback
rachelkang 194d7c4
Merge branch 'main' into xcode13.0-quicklookui-b1
rachelkang ebec4f3
Merge branch 'main' into xcode13.0-quicklookui-b1
rachelkang d8a9f40
Merge branch 'main' into xcode13.0-quicklookui-b1
rachelkang 897a2ba
Merge branch 'main' into xcode13.0-quicklookui-b1
mandel-macaque File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,6 +5,7 @@ | |
|
||
using System; | ||
using System.ComponentModel; | ||
using UniformTypeIdentifiers; | ||
|
||
namespace QuickLookUI { | ||
|
||
|
@@ -172,5 +173,71 @@ interface QLPreviewingController { | |
[Mac (10,15)] | ||
[Export ("preparePreviewOfFileAtURL:completionHandler:")] | ||
void PreparePreviewOfFile (NSUrl url, Action<NSError> completionHandler); | ||
|
||
[iOS (15,0), Mac (12,0), MacCatalyst (15,0)] | ||
[Export ("providePreviewForFileRequest:completionHandler:")] | ||
void ProvidePreview (QLFilePreviewRequest request, Action<QLPreviewReply, NSError> handler); | ||
} | ||
|
||
[NoWatch, NoTV, Mac (12,0), iOS (15,0), MacCatalyst (15,0)] | ||
[BaseType (typeof(NSObject))] | ||
[DisableDefaultCtor] | ||
interface QLFilePreviewRequest | ||
{ | ||
[Export ("fileURL")] | ||
NSUrl FileUrl { get; } | ||
} | ||
|
||
[NoWatch, NoTV, Mac (12,0), iOS (15,0), MacCatalyst (15,0)] | ||
[DisableDefaultCtor] | ||
[BaseType (typeof(NSObject))] | ||
interface QLPreviewProvider : NSExtensionRequestHandling | ||
{ | ||
} | ||
|
||
[NoWatch, NoTV, Mac (12,0), iOS (15,0), MacCatalyst (15,0)] | ||
[BaseType (typeof(NSObject))] | ||
[DisableDefaultCtor] | ||
interface QLPreviewReplyAttachment | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. add there's a |
||
{ | ||
[Export ("data")] | ||
NSData Data { get; } | ||
|
||
[Export ("contentType")] | ||
UTType ContentType { get; } | ||
|
||
[Export ("initWithData:contentType:")] | ||
IntPtr Constructor (NSData data, UTType contentType); | ||
} | ||
|
||
delegate bool QLPreviewReplyDrawingHandler (CGContext context, QLPreviewReply reply, out NSError error); | ||
delegate NSData QLPreviewReplyDataCreationHandler (QLPreviewReply reply, out NSError error); | ||
delegate CGPDFDocument QLPreviewReplyUIDocumentCreationHandler (QLPreviewReply reply, out NSError error); | ||
|
||
[NoWatch, NoTV, Mac (12,0), iOS (15,0), MacCatalyst (15,0)] | ||
[BaseType (typeof(NSObject))] | ||
interface QLPreviewReply | ||
{ | ||
[Export ("stringEncoding")] | ||
NSStringEncoding StringEncoding { get; set; } | ||
|
||
[Export ("attachments", ArgumentSemantic.Copy)] | ||
NSDictionary<NSString, QLPreviewReplyAttachment> Attachments { get; set; } | ||
|
||
[Export ("title")] | ||
string Title { get; set; } | ||
|
||
[Export ("initWithContextSize:isBitmap:drawingBlock:")] | ||
IntPtr Constructor (CGSize contextSize, bool isBitmap, QLPreviewReplyDrawingHandler drawingHandler); | ||
|
||
[Export ("initWithFileURL:")] | ||
IntPtr Constructor (NSUrl fileUrl); | ||
|
||
[Export ("initWithDataOfContentType:contentSize:dataCreationBlock:")] | ||
IntPtr Constructor (UTType contentType, CGSize contentSize, QLPreviewReplyDataCreationHandler dataCreationHandler); | ||
|
||
// QLPreviewReply_UI | ||
[Export ("initForPDFWithPageSize:documentCreationBlock:")] | ||
IntPtr Constructor (CGSize defaultPageSize, QLPreviewReplyUIDocumentCreationHandler documentCreationHandler); | ||
} | ||
} |
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add
[DisableDefaultCtor]
the API seems to be used only inside a protocol and that means the instance is created by the caller (OS) and not by user code
Another hint is that there's no way to set the
FileUrl
property which makes user-created instance not really usable.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All your comments address things I also missed in QuickLook - I'll make a separate PR to correct those in that framework https://github.com/xamarin/xamarin-macios/pull/12337/files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#12402