Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QuickLook] Update based on quicklookui feedback #12402

Merged

Conversation

rachelkang
Copy link
Contributor

@rachelkang rachelkang added the note-highlight Worth calling out specifically in release notes label Aug 10, 2021
@rachelkang rachelkang added this to the xcode13.0 milestone Aug 10, 2021
Copy link
Contributor

@spouliot spouliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 91 tests passed.

Failed tests

  • introspection/Mac Catalyst/Debug [dotnet]: TimedOut (Execution timed out after 1200 seconds.
    No test log file was produced)

Pipeline on Agent XAMBOT-1094.BigSur'
Merge 8b87cab into 300fc28

@rachelkang
Copy link
Contributor Author

test failure is unrelated https://github.com/xamarin/maccore/issues/2414

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build] Tests passed on Build. ✅

Tests passed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

🎉 All 94 tests passed 🎉

Pipeline on Agent XAMBOT-1099.BigSur'
Merge 364ca8d into 2972e1b

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

2 tests failed, 95 tests passed.

Failed tests

  • monotouch-test/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 2638 Passed: 2489 Inconclusive: 35 Failed: 1 Ignored: 148)
  • monotouch-test/watchOS 32-bits - simulator/Debug (LinkSdk): Failed

Pipeline on Agent XAMBOT-1100.BigSur'
Merge 941a8cd into bd7e5c2

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

2 tests failed, 100 tests passed.

Failed tests

  • xammac tests/Mac Modern/Release: Failed (Test run failed.
    Tests run: 2469 Passed: 2403 Inconclusive: 10 Failed: 1 Ignored: 65)
  • monotouch-test/tvOS - simulator/Debug (LinkSdk): Failed

Pipeline on Agent XAMBOT-1097.BigSur'
Merge 17ec345 into b4e828c

@rachelkang
Copy link
Contributor Author

@mandel-macaque could you help me figure out the test failures? in particular, this one seems odd:

[FAIL] GHIssue8342(Unauthorized,"mandel","12345678","","") : Status not ok
Tests run: 2299 Passed: 2282 Inconclusive: 16 Failed: 1 Ignored: 68

@mandel-macaque
Copy link
Member

@rachelkang that is a network test, I'm merging the PR since is unrelated, I have created issue https://github.com/xamarin/maccore/issues/2493 to track it.

@mandel-macaque mandel-macaque merged commit 3af0e34 into xamarin:main Aug 16, 2021
@rachelkang
Copy link
Contributor Author

@mandel-macaque ok, gracias!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
note-highlight Worth calling out specifically in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants