-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QuickLook] Update based on quicklookui feedback #12402
[QuickLook] Update based on quicklookui feedback #12402
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results1 tests failed, 91 tests passed.Failed tests
Pipeline on Agent XAMBOT-1094.BigSur' |
test failure is unrelated https://github.com/xamarin/maccore/issues/2414 |
✅ [PR Build] Tests passed on Build. ✅Tests passed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): 🎉 All 94 tests passed 🎉Pipeline on Agent XAMBOT-1099.BigSur' |
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results2 tests failed, 95 tests passed.Failed tests
Pipeline on Agent XAMBOT-1100.BigSur' |
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results2 tests failed, 100 tests passed.Failed tests
Pipeline on Agent XAMBOT-1097.BigSur' |
@mandel-macaque could you help me figure out the test failures? in particular, this one seems odd: [FAIL] GHIssue8342(Unauthorized,"mandel","12345678","","") : Status not ok |
@rachelkang that is a network test, I'm merging the PR since is unrelated, I have created issue https://github.com/xamarin/maccore/issues/2493 to track it. |
@mandel-macaque ok, gracias! |
Fix things I missed in https://github.com/xamarin/xamarin-macios/pull/12337/files
as per feedback in #12389 (comment)