-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ThreadNetwork] Add new framework Xcode 13 beta 5. #12533
Changes from all commits
36f160d
b24ccb2
5e2d072
d1b9825
2ea1cff
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,74 @@ | ||
using CoreFoundation; | ||
using ObjCRuntime; | ||
using Foundation; | ||
|
||
using System; | ||
|
||
namespace ThreadNetwork { | ||
|
||
[iOS (15,0)] | ||
[BaseType (typeof (NSObject))] | ||
interface THClient | ||
{ | ||
[Async] | ||
[Export ("retrieveAllCredentials:")] | ||
void RetrieveAllCredentials (Action<NSSet<THCredentials>, NSError> completion); | ||
|
||
[Async] | ||
[Export ("deleteCredentialsForBorderAgent:completion:")] | ||
void DeleteCredentialsForBorderAgent (NSData borderAgentId, Action<NSError> completion); | ||
|
||
[Async] | ||
[Export ("retrieveCredentialsForBorderAgent:completion:")] | ||
void RetrieveCredentialsForBorderAgent (NSData borderAgentId, Action<THCredentials, NSError> completion); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. remove |
||
|
||
[Async] | ||
[Export ("storeCredentialsForBorderAgent:activeOperationalDataSet:completion:")] | ||
void StoreCredentialsForBorderAgent (NSData borderAgentId, NSData activeOperationalDataSet, Action<NSError> completion); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. remove There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same. |
||
|
||
[Async] | ||
[Export ("retrievePreferredCredentials:")] | ||
void RetrievePreferredCredentials (Action<THCredentials, NSError> completion); | ||
|
||
[Async] | ||
[Export ("retrieveCredentialsForExtendedPANID:completion:")] | ||
void RetrieveCredentialsForExtendedPanId (NSData extendedPanId, Action<THCredentials, NSError> completion); | ||
} | ||
|
||
[iOS (15,0)] | ||
[BaseType (typeof (NSObject))] | ||
[DisableDefaultCtor] | ||
interface THCredentials : NSSecureCoding | ||
{ | ||
[NullAllowed, Export ("networkName")] | ||
string NetworkName { get; } | ||
|
||
[NullAllowed, Export ("extendedPANID")] | ||
NSData ExtendedPanId { get; } | ||
|
||
[NullAllowed, Export ("borderAgentID")] | ||
NSData BorderAgentId { get; } | ||
|
||
[NullAllowed, Export ("activeOperationalDataSet")] | ||
NSData ActiveOperationalDataSet { get; } | ||
|
||
[NullAllowed, Export ("networkKey")] | ||
NSData NetworkKey { get; } | ||
|
||
[NullAllowed, Export ("PSKC")] | ||
NSData Pskc { get; } | ||
|
||
[Export ("channel")] | ||
byte Channel { get; set; } | ||
|
||
[NullAllowed, Export ("panID")] | ||
NSData PanId { get; } | ||
|
||
[NullAllowed, Export ("creationDate")] | ||
NSDate CreationDate { get; } | ||
|
||
[NullAllowed, Export ("lastModificationDate")] | ||
NSDate LastModificationDate { get; } | ||
} | ||
|
||
} |
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
ForBorderAgent
since it's the first parameter, not the actionThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so, there is a reason for the 'ForBorderAgent'. We have another method called 'RetrieveCredentialsForExtendedPanId' which takes a NsData too, I fear that people will either confuse the NSData between a PanId and a BorderId, so I prefer to be explicit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sense
I'd usually check the swift names - but it looks like they are not (yet?) on the web doc