[ThreadNetwork] Add new framework Xcode 13 beta 5. #12533
Conversation
mandel-macaque
added
the
note-highlight
|
|
||
| [Async] | ||
| [Export ("deleteCredentialsForBorderAgent:completion:")] | ||
| void DeleteCredentialsForBorderAgent (NSData borderAgentId, Action<NSError> completion); |
There was a problem hiding this comment.
remove ForBorderAgent since it's the first parameter, not the action
There was a problem hiding this comment.
I don't think so, there is a reason for the 'ForBorderAgent'. We have another method called 'RetrieveCredentialsForExtendedPanId' which takes a NsData too, I fear that people will either confuse the NSData between a PanId and a BorderId, so I prefer to be explicit.
There was a problem hiding this comment.
make sense
I'd usually check the swift names - but it looks like they are not (yet?) on the web doc
|
|
||
| [Async] | ||
| [Export ("retrieveCredentialsForBorderAgent:completion:")] | ||
| void RetrieveCredentialsForBorderAgent (NSData borderAgentId, Action<THCredentials, NSError> completion); |
There was a problem hiding this comment.
remove ForBorderAgent since it's the first parameter, not the action
|
|
||
| [Async] | ||
| [Export ("storeCredentialsForBorderAgent:activeOperationalDataSet:completion:")] | ||
| void StoreCredentialsForBorderAgent (NSData borderAgentId, NSData activeOperationalDataSet, Action<NSError> completion); |
There was a problem hiding this comment.
remove ForBorderAgent since it's the first parameter, not the action
src/threadnetwork.cs
Outdated
|
|
||
| [Async] | ||
| [Export ("retrieveCredentialsForExtendedPANID:completion:")] | ||
| void RetrieveCredentialsForExtendedPanid (NSData extendedPanid, Action<THCredentials, NSError> completion); |
There was a problem hiding this comment.
remove ForExtendedPanid since it's the first parameter, not the action
There was a problem hiding this comment.
looking at context / doc [1], the first argument should be extendedPanId (uppercase 'I')
[1] Requests Thread credentials for an extended Personal Area Network (PAN) ID.
✅ [PR Build] Tests passed on Build. ✅Tests passed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): 🎉 All 111 tests passed 🎉Pipeline on Agent XAMBOT-1096.BigSur' |
Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
🔥 Tests failed catastrophically on Build (no summary found). 🔥Result file $(TEST_SUMMARY_PATH) not found. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results24 tests failed, 87 tests passed.Failed tests
Pipeline on Agent XAMBOT-1104.BigSur' |
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results27 tests failed, 84 tests passed.Failed tests
Pipeline on Agent XAMBOT-1094.BigSur' |
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results2 tests failed, 109 tests passed.Failed tests
Pipeline on Agent XAMBOT-1105.BigSur' |
|
Unrelated failures. |
No description provided.