[GameKit] Add support for Xcode 15 #19285

haritha-mohan · 2023-10-20T19:38:47Z

No description provided.

github-actions · 2023-10-20T19:43:10Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

github-actions · 2023-10-22T16:06:02Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

rolfbjarne · 2023-10-23T05:55:45Z

src/gamekit.cs

+
+#if XAMCORE_5_0
+		[TV(17, 0), iOS(17, 0), MacCatalyst(17, 0), Mac(14,0)]
+		[Export("challengeComposeControllerWithMessage:players:completion:")]


This needs to be bound as a new method, not replace an existing one in the future, because they have different signatures (the callbacks are different).

mandel-macaque · 2023-10-23T21:43:25Z

tests/xtro-sharpie/api-annotations-dotnet/common-GameKit.ignore

+!missing-field! GKSessionErrorDomain not bound
+!missing-selector! GKLeaderboardEntry::context not bound
+!missing-selector! GKLeaderboardEntry::date not bound
+!missing-selector! GKLeaderboardEntry::formattedScore not bound
+!missing-selector! GKLeaderboardEntry::rank not bound
+!missing-selector! GKLeaderboardEntry::score not bound


Why are these ignored? Looks like they can be bound.

@mandel-macaque tried binding them but still get similar intro failures as the ones mentioned here https://github.com/xamarin/maccore/issues/2269

as discussed in the thread, the GKLeaderboardEntry cannot be directly init, so i can try to figure out how to test them out somehow

haritha-mohan · 2023-10-24T01:45:38Z

tests/xtro-sharpie/common-GameKit.ignore

@@ -1,9 +1,9 @@
 ## All GKSessionError values were deprecated in iOS7 and we never bound then (no point in adding it now)
+!missing-field! GKSessionErrorDomain not bound


also not binding GKSessionErrorDomain due to this

github-actions · 2023-10-24T01:49:22Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

src/gamekit.cs

github-actions · 2023-10-27T11:57:21Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

vs-mobiletools-engineering-service2 · 2023-10-27T13:26:35Z

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-10-27T13:31:14Z

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-10-27T13:32:45Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 73996db3ad36be9af978d743ce6d4fa17bd8203c [PR build]

vs-mobiletools-engineering-service2 · 2023-10-27T13:35:58Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-10-27T13:44:13Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

❗ API diff vs stable (Breaking changes)

Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
macOS: vsdrops gist (No breaking changes)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 73996db3ad36be9af978d743ce6d4fa17bd8203c [PR build]

vs-mobiletools-engineering-service2 · 2023-10-27T15:44:42Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 235 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 6 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 41 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 73996db3ad36be9af978d743ce6d4fa17bd8203c [PR build]

haritha-mohan and others added 2 commits October 20, 2023 12:17

[GameKit] Add support for Xcode 15

fe30cbc

Auto-format source code

3cb24b8

This comment has been minimized.

Sign in to view

haritha-mohan and others added 2 commits October 22, 2023 09:00

fix up

6b1ed49

Auto-format source code

9586caf

This comment has been minimized.

Sign in to view

rolfbjarne requested changes Oct 23, 2023

View reviewed changes

stephen-hawley approved these changes Oct 23, 2023

View reviewed changes

mandel-macaque requested changes Oct 23, 2023

View reviewed changes

address review

550cb8c

haritha-mohan commented Oct 24, 2023

View reviewed changes

haritha-mohan and others added 2 commits October 23, 2023 18:45

Merge branch 'main' into net8.0-xcode15-gamekit

58d32c7

Auto-format source code

9478d12

This comment has been minimized.

Sign in to view

Merge branch 'main' into net8.0-xcode15-gamekit

16438a1

This comment has been minimized.

Sign in to view

Merge branch 'main' into net8.0-xcode15-gamekit

5e68c01

This comment has been minimized.

Sign in to view

dustin-wojciechowski approved these changes Oct 27, 2023

View reviewed changes

rolfbjarne requested changes Oct 27, 2023

View reviewed changes

src/gamekit.cs Outdated Show resolved Hide resolved

haritha-mohan and others added 2 commits October 27, 2023 04:52

fix GKAchievement

df7dfa8

Auto-format source code

73996db

rolfbjarne approved these changes Oct 27, 2023

View reviewed changes

dalexsoto approved these changes Oct 31, 2023

View reviewed changes

mandel-macaque approved these changes Oct 31, 2023

View reviewed changes

haritha-mohan merged commit ca35f94 into xamarin:main Oct 31, 2023
49 checks passed

haritha-mohan deleted the net8.0-xcode15-gamekit branch October 31, 2023 20:20

		@@ -1,9 +1,9 @@
		## All GKSessionError values were deprecated in iOS7 and we never bound then (no point in adding it now)
		!missing-field! GKSessionErrorDomain not bound

[GameKit] Add support for Xcode 15 #19285

[GameKit] Add support for Xcode 15 #19285

Conversation

haritha-mohan commented Oct 20, 2023

github-actions bot commented Oct 20, 2023

⚠️ Your code has been reformatted. ⚠️

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Oct 22, 2023

⚠️ Your code has been reformatted. ⚠️

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne Oct 23, 2023

Choose a reason for hiding this comment

mandel-macaque Oct 23, 2023

Choose a reason for hiding this comment

haritha-mohan Oct 25, 2023

Choose a reason for hiding this comment

haritha-mohan Oct 24, 2023

Choose a reason for hiding this comment

github-actions bot commented Oct 24, 2023

⚠️ Your code has been reformatted. ⚠️

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Oct 27, 2023

⚠️ Your code has been reformatted. ⚠️

vs-mobiletools-engineering-service2 commented Oct 27, 2023

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

vs-mobiletools-engineering-service2 commented Oct 27, 2023

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

vs-mobiletools-engineering-service2 commented Oct 27, 2023

💻 [CI Build] Windows Integration Tests passed 💻

vs-mobiletools-engineering-service2 commented Oct 27, 2023

📚 [PR Build] Artifacts 📚

Packages generated

vs-mobiletools-engineering-service2 commented Oct 27, 2023

✅ API diff for current PR / commit

❗ API diff vs stable (Breaking changes)

ℹ️ Generator diff

vs-mobiletools-engineering-service2 commented Oct 27, 2023

🚀 [CI Build] Test results 🚀

Test results

Tests counts