-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GameKit] Add support for Xcode 15 #19285
Merged
haritha-mohan
merged 14 commits into
xamarin:main
from
haritha-mohan:net8.0-xcode15-gamekit
Oct 31, 2023
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
fe30cbc
[GameKit] Add support for Xcode 15
haritha-mohan 3cb24b8
Auto-format source code
6b1ed49
fix up
haritha-mohan 9586caf
Auto-format source code
550cb8c
address review
haritha-mohan 58d32c7
Merge branch 'main' into net8.0-xcode15-gamekit
haritha-mohan 9478d12
Auto-format source code
a092a6b
add async attr with result type
haritha-mohan 3929d4d
Merge branch 'main' into net8.0-xcode15-gamekit
haritha-mohan f5bf86e
Auto-format source code
16438a1
Merge branch 'main' into net8.0-xcode15-gamekit
haritha-mohan 5e68c01
Merge branch 'main' into net8.0-xcode15-gamekit
haritha-mohan df7dfa8
fix GKAchievement
haritha-mohan 73996db
Auto-format source code
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 6 additions & 0 deletions
6
tests/xtro-sharpie/api-annotations-dotnet/common-GameKit.ignore
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,16 @@ | ||
## All GKSessionError values were deprecated in iOS7 and we never bound then (no point in adding it now) | ||
!missing-field! GKSessionErrorDomain not bound | ||
|
||
## enum size declared after the enum, e.g. `typedef NSInteger GKInviteeResponse;`, so we miss the metadata | ||
!unknown-native-enum! GKInviteeResponse bound | ||
|
||
# Xcode 12 beta 3 - these API are missing | ||
# https://github.com/xamarin/maccore/issues/2269 | ||
!missing-selector! GKLeaderboardEntry::context not bound | ||
!missing-selector! GKLeaderboardEntry::date not bound | ||
!missing-selector! GKLeaderboardEntry::formattedScore not bound | ||
!missing-selector! GKLeaderboardEntry::rank not bound | ||
!missing-selector! GKLeaderboardEntry::score not bound | ||
|
||
## unsorted | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +0,0 @@ | ||
# API removed by Apple, marked as deprecated | ||
13 changes: 0 additions & 13 deletions
13
tests/xtro-sharpie/api-annotations-dotnet/iOS-GameKit.todo
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 0 additions & 14 deletions
14
tests/xtro-sharpie/api-annotations-dotnet/macOS-GameKit.todo
This file was deleted.
Oops, something went wrong.
7 changes: 0 additions & 7 deletions
7
tests/xtro-sharpie/api-annotations-dotnet/tvOS-GameKit.ignore
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +0,0 @@ | ||
!missing-field! GKSessionErrorDomain not bound | ||
!missing-selector! GKLeaderboardEntry::context not bound | ||
!missing-selector! GKLeaderboardEntry::date not bound | ||
!missing-selector! GKLeaderboardEntry::formattedScore not bound | ||
!missing-selector! GKLeaderboardEntry::rank not bound | ||
!missing-selector! GKLeaderboardEntry::score not bound | ||
!missing-selector! GKVoiceChat::playerVoiceChatStateDidChangeHandler not bound | ||
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,14 @@ | ||
## All GKSessionError values were deprecated in iOS7 and we never bound then (no point in adding it now) | ||
!missing-field! GKSessionErrorDomain not bound | ||
|
||
## enum size declared after the enum, e.g. `typedef NSInteger GKInviteeResponse;`, so we miss the metadata | ||
!unknown-native-enum! GKInviteeResponse bound | ||
|
||
# Xcode 12 beta 3 - these API are missing | ||
# https://github.com/xamarin/maccore/issues/2269 | ||
!missing-selector! GKLeaderboardEntry::context not bound | ||
!missing-selector! GKLeaderboardEntry::date not bound | ||
!missing-selector! GKLeaderboardEntry::formattedScore not bound | ||
!missing-selector! GKLeaderboardEntry::rank not bound | ||
!missing-selector! GKLeaderboardEntry::score not bound | ||
|
||
## unsorted |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,11 @@ | ||
# fixed in XAMCORE_3_0 - API break | ||
|
||
|
||
# API removed by Apple, marked as deprecated | ||
!unknown-native-enum! GKAuthenticationType bound | ||
|
||
# Xcode1 4 beta 4 | ||
|
||
# addressed in XAMCORE_5_0 | ||
|
||
!incorrect-protocol-member! GKMatchmakerViewControllerDelegate::matchmakerViewController:didFindHostedPlayers: is OPTIONAL and should NOT be abstract | ||
!incorrect-protocol-member! GKMatchmakerViewControllerDelegate::matchmakerViewController:didFindMatch: is OPTIONAL and should NOT be abstract | ||
!incorrect-protocol-member! GKMatchmakerViewControllerDelegate::matchmakerViewController:didFindPlayers: is OPTIONAL and should NOT be abstract | ||
!incorrect-protocol-member! GKTurnBasedMatchmakerViewControllerDelegate::turnBasedMatchmakerViewController:didFindMatch: is OPTIONAL and should NOT be abstract | ||
!incorrect-protocol-member! GKTurnBasedMatchmakerViewControllerDelegate::turnBasedMatchmakerViewController:playerQuitForMatch: is OPTIONAL and should NOT be abstract |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also not binding GKSessionErrorDomain due to this