CP-39134: add filtering for vTPM API calls #4670
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edwin Török <edvin.torok@citrix.com>
…esting Signed-off-by: Edwin Török <edvin.torok@citrix.com>
Signed-off-by: Edwin Török <edvin.torok@citrix.com>
Check that basic API calls get forwarded Signed-off-by: Edwin Török <edvin.torok@citrix.com>
Signed-off-by: Edwin Török <edvin.torok@citrix.com>
…e socket This is the socket created by xapi-guard itself through Conduit, but Conduit doesn't currently have an API to notify us when the socket got created and listen()-ed on. And we don't want to return too early to our caller (the unit test or xenopsd) since they may get an ECONNREFUSED if they try to connect too early. Signed-off-by: Edwin Török <edvin.torok@citrix.com>
Instead of `foo () >>= fun result -> ...` use `let* result = foo () in ...`. Instead of `foo () >|= fun result -> ...` use `let+ result = foo () in ...`. Signed-off-by: Edwin Török <edvin.torok@citrix.com>
Signed-off-by: Edwin Török <edvin.torok@citrix.com>
Signed-off-by: Edwin Török <edvin.torok@citrix.com>
psafont
reviewed
Apr 6, 2022
psafont
reviewed
Apr 6, 2022
psafont
approved these changes
Apr 6, 2022
Signed-off-by: Edwin Török <edvin.torok@citrix.com>
Signed-off-by: Edwin Török <edvin.torok@citrix.com>
|
Are there salvageable commits here? (I was thinking about the unit-testing) |
|
Opened ticket to salvage unit tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swtpm runs in a sandbox and has access to a socket on which it can talk to XAPI.
xapi-guard is used to whitelist what API calls it can make, such that it can only access and change its own VM, and not other VMs.
This is already done for varstored and NVRAM API calls, implement filtering for VTPM API calls similarly.
Also add unit tests, and refactor/clean up the code a bit.