CP-40116 xapi-guard: Add unit tests #4813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psafont
force-pushed
the
private/paus/guard-tests
branch
from
c2d1add
to
5a91e42
Compare
|
The FD leak test is noisy, there's probably some interference with dune and opam |
|
I'm unable to reproduce the failure locally, neither with dune or opam nor without them: |
lindig
approved these changes
Oct 11, 2022
| avoid using up 100% CPU waiting for it, | ||
| better than Lwt.pause () | ||
| *) | ||
| let* () = Lwt_unix.sleep 0.001 in |
There was a problem hiding this comment.
The wait is a lot shorter now. Is this just for Lwt scheduling?
There was a problem hiding this comment.
This is for getting the unit tests to pass quickly while still yielding the CPU to other tasks, see #4670 (comment)
psafont
force-pushed
the
private/paus/guard-tests
branch
5 times, most recently
from
d15b774
to
e6921da
Compare
…esting Signed-off-by: Edwin Török <edvin.torok@citrix.com> Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
Signed-off-by: Edwin Török <edvin.torok@citrix.com> Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
Check that basic API calls get forwarded Signed-off-by: Edwin Török <edvin.torok@citrix.com> Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
Signed-off-by: Edwin Török <edvin.torok@citrix.com> Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
…e socket This is the socket created by xapi-guard itself through Conduit, but Conduit doesn't currently have an API to notify us when the socket got created and listen()-ed on. And we don't want to return too early to our caller (the unit test or xenopsd) since they may get an ECONNREFUSED if they try to connect too early. Signed-off-by: Edwin Török <edvin.torok@citrix.com> Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
Instead of `foo () >>= fun result -> ...` use `let* result = foo () in ...`. Instead of `foo () >|= fun result -> ...` use `let+ result = foo () in ...`. Signed-off-by: Edwin Török <edvin.torok@citrix.com> Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
Signed-off-by: Edwin Török <edvin.torok@citrix.com> Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
Signed-off-by: Edwin Török <edvin.torok@citrix.com> Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
The test is commented out because under certain conditions which couldn't be replicated at the end there are _less_ file descriptors that at the beginning. Signed-off-by: Edwin Török <edvin.torok@citrix.com> Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
psafont
force-pushed
the
private/paus/guard-tests
branch
from
e6921da
to
fbc216f
Compare
jameshensmancitrix
approved these changes
Oct 26, 2022
psafont
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were developed in conjunction with a deprivileged interface to gather vtpm data, but it was dropped: #4670
I've removed that part of the tests and kept the rest, including an file descriptor leak test that found actually found one. The fix was included in the codebase months ago.