Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cf conventions use units that follow the structure of
{time_units} since {date}
to encode calendar dates to numeric arrays (integers / floats). Whenxarray
decodes datasets, it uses these datetime units to convert the numeric arrays to datetime arrays (and the other way around when encoding).However, these datetime units can still be on variables, for example if a user sets
decode_times=False
. In that case, we would pick up those units and try to parse them, only to fail immediately becausepint
cannot understand them (nor should it).This PR makes
extract_unit_attributes
andstrip_unit_attributes
skip any of these units, making it seem as if theunits
attribute didn't exist / wasNone
(the attribute will still be there, though).cc @jbusecke, @TomNicholas, @dcherian
pre-commit run --all-files
whats-new.rst