Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update example notebooks #71

Merged
merged 2 commits into from
May 26, 2023
Merged

Update example notebooks #71

merged 2 commits into from
May 26, 2023

Conversation

pont-us
Copy link
Member

@pont-us pont-us commented May 5, 2023 •
edited
Loading

Update example notebooks to create CDS store using new_data_store, and remove some unnecessary imports. Also remove the superfluous read_grib.ipynb notebook.

Closes #70 .

pont-us added 2 commits May 5, 2023 14:50
@pont-us
Update notebooks to use new_data_store
b4805c7 
With this commit, the example notebooks no longer instantiate
CDSDataStore directly, but via xcube.core.store.new_data_store.

Addresses #70.
@pont-us
Remove GRIB-reading example notebook
0dc8b71 
This notebook didn't use the xcube-cds store, so wasn't really
relevant as an example.
@pont-us pont-us requested a review from forman May 5, 2023 15:14
@pont-us pont-us merged commit 87be329 into master May 26, 2023
@pont-us pont-us deleted the pont-70-update-notebooks branch June 7, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@forman forman forman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update example notebooks to use new_data_store
2 participants
@pont-us @forman