Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addressing #420 (for CCI Toolbox) #51

Merged
merged 4 commits into from
Mar 17, 2021
Merged

Addressing #420 (for CCI Toolbox) #51

merged 4 commits into from
Mar 17, 2021

Conversation

forman
Copy link
Member

@forman forman commented Mar 10, 2021 •
edited
Loading

EDIT

Requires merged xcube-dev/xcube#421

@forman forman requested a review from TonioF March 10, 2021 10:43
@forman forman self-assigned this Mar 10, 2021
TonioF
TonioF approved these changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@TonioF TonioF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On single comment about a todo, otherwise fine!

@forman forman requested a review from TonioF March 16, 2021 10:18
@TonioF TonioF merged commit f879040 into master Mar 17, 2021
@TonioF TonioF deleted the forman-420-include_attrs branch March 17, 2021 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TonioF TonioF Awaiting requested review from TonioF

Assignees

@forman forman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@forman @TonioF