Addressing #420 (for CCI Toolbox) #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 10, 2021
…aset_ids(). Due to this, change to 0.8.0
…aset_ids(). Due to this, change to 0.8.0
…aset_ids(). Due to this, change to 0.8.0
TonioF
requested changes
Mar 11, 2021
| omitted, all available data identifiers are returned. | ||
| :param include_titles: If true, the store will attempt to also provide a title. | ||
| If a store implementation supports only a single data type, it should verify that | ||
| *type_specifier* is either None or compatible with the supported data type. |
There was a problem hiding this comment.
If a store implementation supports only a single data type, it should verify that type_specifier is either None or compatible with the supported data type. -> A store implementation should verify that type_specifier is either None or compatible with a supported data type.
|
One more thing: Four tests fail. |
|
And, I'm sorry: Where do we put the information what attributes a store offers? |
Co-authored-by: Tonio Fincke <tonio.fincke@brockmann-consult.de>
Co-authored-by: Tonio Fincke <tonio.fincke@brockmann-consult.de>
We'll define a set of common and generic attributes that may be requested here. We put them in the method's docstring later. |
…attrs # Conflicts: # CHANGES.md # xcube/version.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xcube.core.store.DataStore.get_dataset_ids()by adding a new keyword argument
include_attrs: Sequence[str] = Nonethatcan be used to obtain a minimum set of dataset attributes for each returned
dataset identifier. However,
include_attrsis ignored to far in the "s3","memory", and "directory" data stores. (DataStore.get_data_ids() to return minimum set of attributes #420)
Checklist:
Add unit tests and/or doctests in docstringsNew/modified features documented indocs/source/*docs/CHANGES.md