Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Categorical color mapping #338

Merged
merged 35 commits into from
May 21, 2024
Merged

Categorical color mapping #338

merged 35 commits into from
May 21, 2024

Conversation

forman
Copy link
Member

@forman forman commented May 13, 2024

Users can now select the data normalisation function to be applied before the actual color mapping takes place. Three functions are available:

  • Lin: linear mapping of data values between min and max to colors.
  • Log: logarithmic mapping of data values between vmin and vmax to colors.
  • Cat: direct mapping of categorical data values into colors.

This PR requires xcube server as of xcube-dev/xcube#977.

@forman forman self-assigned this May 13, 2024
@forman forman marked this pull request as ready for review May 14, 2024 15:42
@forman forman marked this pull request as draft May 14, 2024 15:52
@forman forman marked this pull request as ready for review May 16, 2024 09:31
@forman forman requested a review from ruchimotwaniBC May 16, 2024 09:31
@@ -39,7 +39,7 @@ const colorBarItemStyle = (theme: Theme) => ({
const useItemStyles = makeStyles((theme: Theme) => ({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makeStyles is also imported from @mui/styles which is now legacy, so may be we can get rid of makeStlyes and adapt styled or sx

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, of course. I will adapt all the components. I have not yet started this.

@forman forman merged commit 12113b3 into main May 21, 2024
3 checks passed
@forman forman deleted the forman-categorical_color_bars branch May 21, 2024 12:43
@forman forman mentioned this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants