-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Categorical color mapping #338
Merged
Merged
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
a859524
introduces new user color bar prop "categorical"
forman 552adfb
Merge branch 'refs/heads/main' into forman-categorical_color_bars
forman f60900b
changed color bar models to support categories incl. labels
forman 1eb7345
fixed tests
forman 66fd33c
fix: only if categorical
forman 34e9eb2
remove unneeded components
forman cd10ad7
avoid closing color bar selector if making color bar categorical
forman 7482e29
works
forman 219be74
now also rendering categorical color bars
forman 17f2838
Merge branch 'refs/heads/main' into forman-categorical_color_bars
forman 8153220
better color item border colors
forman 32090f0
introduced property Variable.colorBarNorm and set tile query param "n…
forman 9e46a99
UserColorBar.categorical --> UserColorBar.discrete
forman ba1a3c8
Can now switch color bar norm
forman 4038a04
Update
forman 414650a
introduced ColorMapType
forman 661da49
Disable normalisation "cat" if we do not have categories
forman 1ee72f1
Normalisation "cat" now works
forman e2cc2a7
Adjust min/max range for log normalisation
forman e376810
Fixed test
forman f071bdf
renamed user color bar type "index" into "key"
forman 883c036
Merge branch 'refs/heads/main' into forman-categorical_color_bars
forman 432c92c
labels now recognise log-scaling
forman fc2a5c1
Merge branch 'refs/heads/main' into forman-categorical_color_bars
forman 4abd725
Merge branch 'refs/heads/main' into forman-categorical_color_bars
forman 509229e
Merge branch 'refs/heads/main' into forman-categorical_color_bars
forman f107c40
Merge branch 'refs/heads/main' into forman-categorical_color_bars
forman 2e7b93b
log-scaled range slider
forman 4cf8f0b
Merge branch 'refs/heads/main' into forman-categorical_color_bars
forman 0585898
Merge branch 'refs/heads/forman-categorical_color_bars' into forman-l…
forman aa5160c
Seems to work now, but value formatting is not optimal
forman 94aff87
It works now
forman f729a66
refactorings
forman 9eaa3bf
Changing range in text boxes now updates slider correctly
forman 5b21335
increased dev version
forman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makeStyles is also imported from @mui/styles which is now legacy, so may be we can get rid of makeStlyes and adapt styled or sx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, of course. I will adapt all the components. I have not yet started this.