Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spatial cube subset by geometry #148

Closed
forman opened this issue Aug 12, 2019 · 0 comments · Fixed by #150
Closed

Spatial cube subset by geometry #148

forman opened this issue Aug 12, 2019 · 0 comments · Fixed by #150
Assignees
@forman
Labels
enhancement New feature or request important This is very important for the project urgent High external pressure to address this ASAP

Comments

@forman
Copy link
Member

forman commented Aug 12, 2019

Is your feature request related to a problem? Please describe.

Create a cube spatial subset by a geometry such as a polygon.

Describe the solution you'd like

Solution already exists but is yet "hidden" as xcube.util.geom.where_geometry() function. Publish it it to xcube.api, add docs and add any important function options.

Additional context

Important to have it in the DCFS demo use case.
@forman forman added enhancement New feature or request in progress The assignee is working on it urgent High external pressure to address this ASAP important This is very important for the project labels Aug 12, 2019
@forman forman self-assigned this Aug 12, 2019
forman added a commit that referenced this issue Aug 13, 2019
@forman
* Added new spatial dataset operations to xcube.api:
c18a0b0 
  * `mask_dataset_by_geometry(dataset, geometry_like)` clip and mask a dataset by geometry
  * `clip_dataset_by_geometry(dataset, geometry_like)` just clip a dataset by geometry
  * `convert_geometry(geometry_like)` convert a geometry-like into a shapely geometry
* Renamed type `Geometry` into `GeometryLike`
* Fixed clipping of datasets (clip bounds were by 1 too large in x,y directions)
* Fixed conversion of geometry-like objects if GeoJSON dicts were passed
* Added a lot of missing tests, adapted tests

Closes #148
@forman forman mentioned this issue Aug 13, 2019
Merged
@forman forman removed the in progress The assignee is working on it label Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@forman forman

Labels
enhancement New feature or request important This is very important for the project urgent High external pressure to address this ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Forman 148 subset by geometry xcube-dev/xcube
1 participant
@forman