Forman 148 subset by geometry #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `mask_dataset_by_geometry(dataset, geometry_like)` clip and mask a dataset by geometry * `clip_dataset_by_geometry(dataset, geometry_like)` just clip a dataset by geometry * `convert_geometry(geometry_like)` convert a geometry-like into a shapely geometry * Renamed type `Geometry` into `GeometryLike` * Fixed clipping of datasets (clip bounds were by 1 too large in x,y directions) * Fixed conversion of geometry-like objects if GeoJSON dicts were passed * Added a lot of missing tests, adapted tests Closes #148
Codecov Report
@@ Coverage Diff @@
## master #150 +/- ##
==========================================
+ Coverage 85.62% 85.67% +0.04%
==========================================
Files 72 72
Lines 6743 6812 +69
==========================================
+ Hits 5774 5836 +62
- Misses 969 976 +7
Continue to review full report at Codecov.
|
dzelge
approved these changes
Aug 13, 2019
|
When using the xcube.api from this branch in a jupyter lab, I still get an error when trying to import a geojson: |
|
You load a feature or feature collection, not a geometry. |
AliceBalfanz
approved these changes
Aug 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xcube.api:mask_dataset_by_geometry(dataset, geometry_like)clip and mask a dataset by geometryclip_dataset_by_geometry(dataset, geometry_like)just clip a dataset by geometryconvert_geometry(geometry_like)convert a geometry-like into a shapely geometryGeometryintoGeometryLikeCloses #148
@AliceBalfanz to merge this PR asap
Sorry, the PR became quite large.