Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests to work with moto 5.0.0 and pytest 8.0.0 #923

Merged
merged 3 commits into from
Jan 31, 2024
Merged

Update tests to work with moto 5.0.0 and pytest 8.0.0 #923

merged 3 commits into from
Jan 31, 2024

Conversation

pont-us
Copy link
Member

@pont-us pont-us commented Jan 30, 2024 •
edited
Loading

Closes #922.

  • Omit "s3" argument when starting moto server: moto 5 no longer supports the service argument, and it is not needed.
  • Specify expected warnings explicitly in pytest.warns usages in test_main, since former None argument is no longer supported in pytest 8.0.0.

Checklist:

  • [ ] Add unit tests and/or doctests in docstrings n/a
  • [ ] Add docstrings and API docs for any new/modified user-facing classes and functions n/a
  • [ ] New/modified features documented in docs/source/* n/a
  • Changes documented in CHANGES.md
  • GitHub CI passes
  • AppVeyor CI passes
  • Test coverage remains or increases (target 100%)

@pont-us
Omit "s3" argument when starting moto server
964da12 
Fixes #922

moto 5 no longer supports the service argument, and it is not needed.
@pont-us
Update some pytest.warns usages for pytest 8
daee65a 
Fixes two tests that were erroring with pytest 8 due to an
API change.

Addresses #922.
@pont-us pont-us changed the title Omit "s3" argument when starting moto server Update tests to work with moto 5.0.0 and pytest 8.0.0 Jan 31, 2024
pont-us added a commit that referenced this pull request Jan 31, 2024
@pont-us
Merge fixes from PR 923 branch into PR 925 branch
24827ed 
Pre-merging the unit test updates from PR #923 into PR #925
to make the test suite pass in this PR before it's merged into
master.
@pont-us pont-us requested a review from forman January 31, 2024 13:58
forman
forman approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@forman forman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pont-us pont-us merged commit bb2f395 into master Jan 31, 2024
4 checks passed
@pont-us pont-us deleted the pont-922-fix-moto-error branch February 1, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@forman forman forman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some tests failing with moto 5.0.0 and pytest 8.0.0
2 participants
@pont-us @forman