Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename some test classes to avoid spurious warnings #925

Merged
merged 3 commits into from
Jan 31, 2024

Conversation

pont-us
Copy link
Member

@pont-us pont-us commented Jan 31, 2024

Fixes #924.

Checklist:

  • [ ] Add unit tests and/or doctests in docstrings n/a
  • [ ] Add docstrings and API docs for any new/modified user-facing classes and functions n/a
  • [ ] New/modified features documented in docs/source/* n/a
  • Changes documented in CHANGES.md
  • GitHub CI passes
  • AppVeyor CI passes
  • Test coverage remains or increases (target 100%)

Pre-merging the unit test updates from PR #923 into PR #925
to make the test suite pass in this PR before it's merged into
master.
@pont-us pont-us marked this pull request as ready for review January 31, 2024 13:35
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bb140fb) 93.43% compared to head (24827ed) 93.46%.
Report is 5 commits behind head on master.

❗ Current head 24827ed differs from pull request most recent head 24162d2. Consider uploading reports for the commit 24162d2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #925      +/-   ##
==========================================
+ Coverage   93.43%   93.46%   +0.02%     
==========================================
  Files         453      453              
  Lines       35518    35518              
==========================================
+ Hits        33188    33196       +8     
+ Misses       2330     2322       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pont-us pont-us requested a review from forman January 31, 2024 14:53
Copy link
Member

@forman forman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pont-us pont-us merged commit e3d0ec4 into master Jan 31, 2024
1 of 2 checks passed
@pont-us pont-us deleted the pont-924-pytest-warnings branch February 1, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pytest issues spurious warnings about classes with __init__ methods
2 participants