Fixes #191. Add Configuration doesn't show PHP #194
Conversation
When selecting `Add Configuration` in a VS Code launch.json file PHP is no longer shown as an option. The new `configurationSnippets` resolves this.
Codecov Report
@@ Coverage Diff @@
## master #194 +/- ##
=======================================
Coverage 76.34% 76.34%
=======================================
Files 2 2
Lines 93 93
Branches 17 17
=======================================
Hits 71 71
Misses 14 14
Partials 8 8Continue to review full report at Codecov.
|
| @@ -188,20 +188,28 @@ | |||
| } | |||
| } | |||
| }, | |||
| "initialConfigurations": [ | |||
There was a problem hiding this comment.
Why did you remove initialConfigurations?
There was a problem hiding this comment.
we can reserve initialConfigurations and add configurationSnippets like the third suggestion in #318.
There was a problem hiding this comment.
fwiw
"configurationSnippets": [
{
"label": "PHP: Listen for XDebug",
"description": "Listening for XDebug",
"body": {
"name": "Listen for XDebug",
"type": "php",
"request": "launch",
"port": 9000
}
},
{
"label": "PHP: Launch currently open script",
"description": "Launch currently open script",
"body": {
"name": "Launch currently open script",
"type": "php",
"request": "launch",
"program": "^\"${1:\\${file\\}}\"",
"cwd": "^\"${2:\\${fileDirname\\}}\"",
"port": 9000
}
}
]
|
I tried to apply this PR to main, but can’t seem to get it working. The snippets that show up in launch.json do not include these defined here. I tried to build and install the extension locally. The structure also seem similar to other adapters of the same kind. Any ideas? |
|
Due to larger refactors of the codebase I decided to reimplement the fix with additional changes. Moved the code to #527. |
When selecting
Add Configurationin a VS Code launch.json file PHP is no longer shown as an option. The newconfigurationSnippetsresolves this.