Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #191. Add Configuration doesn't show PHP #194

Closed
wants to merge 3 commits into from
Closed
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 19 additions & 11 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -188,20 +188,28 @@
}
}
},
"initialConfigurations": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove initialConfigurations?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can reserve initialConfigurations and add configurationSnippets like the third suggestion in #318.

Copy link

@tom-shan tom-shan Apr 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw

        "configurationSnippets": [
          {
            "label": "PHP: Listen for XDebug",
            "description": "Listening for XDebug",
            "body": {
              "name": "Listen for XDebug",
              "type": "php",
              "request": "launch",
              "port": 9000
            }
          },
          {
            "label": "PHP: Launch currently open script",
            "description": "Launch currently open script",
            "body": {
              "name": "Launch currently open script",
              "type": "php",
              "request": "launch",
              "program": "^\"${1:\\${file\\}}\"",
              "cwd": "^\"${2:\\${fileDirname\\}}\"",
              "port": 9000
            }
          }
        ]

"configurationSnippets": [
{
"name": "Listen for XDebug",
"type": "php",
"request": "launch",
"port": 9000
"label": "PHP: Listen for XDebug",
"description": "Listen for incoming XDebug connections",
"body": {
"name": "Listen for XDebug",
"type": "php",
"request": "launch",
"port": 9000
}
},
{
"name": "Launch currently open script",
"type": "php",
"request": "launch",
"program": "${file}",
"cwd": "${fileDirname}",
"port": 9000
"label": "PHP: Launch currently open script",
"description": "Debug the currently open PHP script in CLI mode",
"body": {
"name": "Launch currently open script",
"type": "php",
"request": "launch",
"program": "${file}",
"cwd": "${fileDirname}",
"port": 9000
}
}
]
}
Expand Down