Migrate from winapi to windows-sys. #62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR migrates dirs-sys-next from winapi to windows-sys. Windows-sys is actively maintained, by Microsoft, and has recently started to be adopted in the ecosystem; mio, parking_lot, wasmtime, and others have moved to windows-sys. Migrating dirs-sys-next to windows-sys will help me remove one more of Wasmtime's transitive dependencies on winapi.
This fixes the following clippy error:
```
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> dirs-sys/src/lib.rs:141:54
|
141 | let result = Shell::SHGetKnownFolderPath(folder_id, 0, 0, &mut path_ptr);
| ^^^^^^^^^
|
= note: `#[deny(clippy::not_unsafe_ptr_arg_deref)]` on by default
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
```
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates dirs-sys-next from winapi to windows-sys.
Windows-sys is actively maintained, by Microsoft, and has recently
started to be adopted in the ecosystem; mio, parking_lot, wasmtime,
and others have moved to windows-sys.
Migrating dirs-sys-next to windows-sys will help me remove one more of
Wasmtime's transitive dependencies on winapi.