-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from winapi to windows-sys. #62
Open
sunfishcode
wants to merge
7
commits into
xdg-rs:master
Choose a base branch
from
sunfishcode:windows-sys
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Jul 1, 2022
-
Migrate from winapi to windows-sys.
This PR migrates dirs-sys-next from winapi to windows-sys. Windows-sys is actively maintained, by Microsoft, and has recently started to be adopted in the ecosystem; mio, parking_lot, wasmtime, and others have moved to windows-sys. Migrating dirs-sys-next to windows-sys will help me remove one more of Wasmtime's transitive dependencies on winapi.
Configuration menu - View commit details
-
Copy full SHA for 65539ea - Browse repository at this point
Copy the full SHA 65539eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 77f240a - Browse repository at this point
Copy the full SHA 77f240aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 80573e7 - Browse repository at this point
Copy the full SHA 80573e7View commit details
Commits on Jul 20, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 4258e3d - Browse repository at this point
Copy the full SHA 4258e3dView commit details -
This fixes the following clippy error: ``` error: this public function might dereference a raw pointer but is not marked `unsafe` --> dirs-sys/src/lib.rs:141:54 | 141 | let result = Shell::SHGetKnownFolderPath(folder_id, 0, 0, &mut path_ptr); | ^^^^^^^^^ | = note: `#[deny(clippy::not_unsafe_ptr_arg_deref)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref ```
Configuration menu - View commit details
-
Copy full SHA for 834c830 - Browse repository at this point
Copy the full SHA 834c830View commit details
Commits on Nov 11, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 4fc26cd - Browse repository at this point
Copy the full SHA 4fc26cdView commit details
Commits on Mar 8, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 6e79c83 - Browse repository at this point
Copy the full SHA 6e79c83View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.