Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Add optional attributes to declarative assembly format #2407

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

lucjaulmes
Copy link
Collaborator

I was going to suggest the missing optional $inner_sym attr on #2404 but realised optional attributes don’t exist yet in the declarative format. It seemed a rather trivial extension so here’s my shot at it, let me know if something misses/feels wrong.

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 89.68%. Comparing base (d1f2cad) to head (48f5cd8).

Files Patch % Lines
xdsl/irdl/declarative_assembly_format.py 83.33% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2407   +/-   ##
=======================================
  Coverage   89.68%   89.68%           
=======================================
  Files         346      346           
  Lines       41418    41465   +47     
  Branches     6175     6183    +8     
=======================================
+ Hits        37144    37188   +44     
  Misses       3372     3372           
- Partials      902      905    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucjaulmes
Copy link
Collaborator Author

I’ve added optional property too to fix coverage issues and for completeness.

@compor compor self-requested a review April 3, 2024 15:07
@lucjaulmes lucjaulmes merged commit 9eec34d into xdslproject:main Apr 8, 2024
10 checks passed
@superlopuh superlopuh added the core xDSL core (ir, textual format, ...) label Apr 8, 2024
lucjaulmes added a commit that referenced this pull request Apr 12, 2024
Now #2448 and #2407 are in we can finally complete what was left out of
#2404:
- an optional attribute `inner_sym` 
- the second optional operand `powerOn`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core xDSL core (ir, textual format, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants