dialects: (seq) Finish seq.compreg optionals
#2450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also simplify the verification a tad
lucjaulmes
changed the title
seq.compreg optionalsseq.compreg optionals
superlopuh
approved these changes
Apr 11, 2024
Moxinilian
approved these changes
Apr 12, 2024
There was a problem hiding this comment.
Looks good! CIRCT seems to have a lot of places where it cares about SSA names being consistent (with the option to set names separately otherwise), but considering this was fairly complex when I implemented it in HwModule, I think it's better if we only add it when truly necessary. I think all the xDSL features to do it are here but it would probably require some refactoring to do it properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now #2448 and #2407 are in we can finally complete what was left out of #2404:
inner_sympowerOn