dialects: (x86) PR10 - RRI Operations #2524
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2524 +/- ##
==========================================
- Coverage 89.85% 89.85% -0.01%
==========================================
Files 351 351
Lines 43938 43963 +25
Branches 6559 6562 +3
==========================================
+ Hits 39481 39501 +20
- Misses 3500 3505 +5
Partials 957 957 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com>
Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com>
| """ | ||
|
|
||
| r2 = operand_def(R2InvT) | ||
| immediate: AnyIntegerAttr = attr_def(AnyIntegerAttr) |
There was a problem hiding this comment.
Does x86 specify the bitcount of the immediate values?
There was a problem hiding this comment.
According to the x86 manual immediates can only have 8, 16 or 32 bits (with 32 being the default I believe) with 64 bit immediates only appearing for rare instructions afaik.
There was a problem hiding this comment.
The configuration im targetting also implies a 32 bit immediate
There was a problem hiding this comment.
Ok, feels like we might want to encode that at some point, but not urgently
There was a problem hiding this comment.
good to merge then?
Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com>
Added support for instructions with 1 destination register, one source register and one immediate.