-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backend: (riscv) riscv-prologue-epilogue-insertion #2778
backend: (riscv) riscv-prologue-epilogue-insertion #2778
Conversation
…mmediately if no callee-preserved registers are used; test_get_all_available_passes is changed to adjust the output to the expected one (temporary workaround)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2778 +/- ##
==========================================
- Coverage 89.80% 89.80% -0.01%
==========================================
Files 376 381 +5
Lines 48091 48227 +136
Branches 7371 7378 +7
==========================================
+ Hits 43187 43309 +122
- Misses 3756 3765 +9
- Partials 1148 1153 +5 ☔ View full report in Codecov by Sentry. |
Could you also add a test-case to the existing tests in https://github.com/xdslproject/xdsl/blob/ad76f511b94bdfa4d51979d0e41fd52908a61521/tests/filecheck/backend/riscv/prologue_epilogue_insertion.mlir? A simple function that does not use callee-saved registers + a |
Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com>
Updated, take a look please |
Co-authored-by: Markus Böck <markus.boeck02@gmail.com>
Riscv-prologue-epilogue-insertion pass ensures compatibility with RISC-V ABI in terms of preserving the content of callee-saved registers. This brief PR adds the immediate return from the pass in case no callee-saved registers are used by the function, thus preventing the issuing of unnecessary
addi sp, sp, 0
.test_get_all_available_passes
is changed to adjust the output to the expected one (temporary workaround).