dialects (arm): add mov op #3476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3476 +/- ##
==========================================
+ Coverage 90.26% 90.33% +0.06%
==========================================
Files 462 464 +2
Lines 57820 58157 +337
Branches 5565 5557 -8
==========================================
+ Hits 52192 52536 +344
+ Misses 4191 4190 -1
+ Partials 1437 1431 -6 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
superlopuh
approved these changes
Nov 19, 2024
alexarice
reviewed
Nov 19, 2024
xdsl/dialects/arm/ops.py
Outdated
| @irdl_op_definition | ||
| class DSMovOp(ARMOperation): | ||
| """ | ||
| Copies the value of r1 into r2. |
There was a problem hiding this comment.
thanks, this should be operand(2) and rd
xdsl/dialects/arm/ops.py
Outdated
| name = "arm.ds.mov" | ||
|
|
||
| rd = result_def(IntRegisterType) | ||
| operand2 = operand_def(IntRegisterType) |
There was a problem hiding this comment.
Having an operand2 but no operand feels odd
There was a problem hiding this comment.
this is just following the ARM documentation for this instruction (https://developer.arm.com/documentation/dui0473/m/arm-and-thumb-instructions/mov), but I can change it
superlopuh
reviewed
Nov 19, 2024
superlopuh
reviewed
Nov 19, 2024
superlopuh
reviewed
Nov 19, 2024
Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com>
Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com>
alexarice
approved these changes
Nov 20, 2024
xdsl/dialects/arm/ops.py
Outdated
| s: Operation | SSAValue, | ||
| *, | ||
| comment: str | StringAttr | None = None, | ||
| d: IntRegisterType, |
There was a problem hiding this comment.
I would personally put this as a positional argument.
Add assembly printing for ARM instructions Note: stacked PR --------- Co-authored-by: emmau678 <eu233@Emma-laptop> Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com>
EdmundGoodman
pushed a commit
to EdmundGoodman/xdsl
that referenced
this pull request
Dec 6, 2024
Add a mov op that moves data from source to destination --------- Co-authored-by: emmau678 <eu233@Emma-laptop> Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a mov op that moves data from source to destination