Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects: (builtin) shape for DenseIntORFPElementsAttr is always known #3534

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

jorendumoulin
Copy link
Collaborator

As they only work for ranked structures, the shape will always be not None

@jorendumoulin jorendumoulin self-assigned this Nov 28, 2024
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.35%. Comparing base (6f203de) to head (2db0da8).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3534   +/-   ##
=======================================
  Coverage   90.35%   90.35%           
=======================================
  Files         466      466           
  Lines       58481    58476    -5     
  Branches     5582     5580    -2     
=======================================
- Hits        52841    52838    -3     
+ Misses       4210     4209    -1     
+ Partials     1430     1429    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@math-fehr math-fehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jorendumoulin jorendumoulin merged commit c624080 into main Nov 28, 2024
15 checks passed
@jorendumoulin jorendumoulin deleted the joren/dense-shape-is-not-none branch November 28, 2024 13:47
@jorendumoulin jorendumoulin added the dialects Changes on the dialects label Nov 28, 2024
EdmundGoodman pushed a commit to EdmundGoodman/xdsl that referenced this pull request Dec 6, 2024
xdslproject#3534)

As they only work for ranked structures, the shape will always be not
None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialects Changes on the dialects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants