Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects: (builtin) shape for DenseIntORFPElementsAttr is always known #3534

Merged
merged 2 commits into from
Nov 28, 2024
Merged

dialects: (builtin) shape for DenseIntORFPElementsAttr is always known #3534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1423d52
dialects: (builtin) shape for DenseIntORFPElementsAttr is always known
jorendumoulin Nov 28, 2024
2db0da8
additional
jorendumoulin Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions xdsl/dialects/builtin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1733,9 +1733,7 @@ class DenseIntOrFPElementsAttr(TypedAttribute, ContainerType[AnyDenseElement]):
data: ParameterDef[ArrayAttr[AnyIntegerAttr] | ArrayAttr[AnyFloatAttr]]

# The type stores the shape data
def get_shape(self) -> tuple[int, ...] | None:
if isinstance(self.type, UnrankedTensorType):
return None
def get_shape(self) -> tuple[int, ...]:
return self.type.get_shape()

def get_element_type(self) -> IntegerType | IndexType | AnyFloat:
Expand All @@ -1744,8 +1742,6 @@ def get_element_type(self) -> IntegerType | IndexType | AnyFloat:
@property
def shape_is_complete(self) -> bool:
shape = self.get_shape()
if shape is None or not len(shape):
return False

n = 1
for dim in shape:
Expand Down
2 changes: 1 addition & 1 deletion xdsl/interpreters/builtin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,4 +94,4 @@ def dense_int_or_fp_elements_value(
attr.get_element_type(), interpreter.index_bitwidth
),
)
return ShapedArray(data_ptr, list(shape) if shape is not None else [])
return ShapedArray(data_ptr, list(shape))
2 changes: 0 additions & 2 deletions xdsl/interpreters/ml_program.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,6 @@ def run_global_load_constant(
global_value = global_op.value
assert isinstance(global_value, DenseIntOrFPElementsAttr)
shape = global_value.get_shape()
if shape is None:
raise NotImplementedError()
xtype = xtype_for_el_type(
global_value.get_element_type(), interpreter.index_bitwidth
)
Expand Down
2 changes: 1 addition & 1 deletion xdsl/interpreters/onnx.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ def run_constant(
op.value.get_element_type(), interpreter.index_bitwidth
),
)
return (ShapedArray(data_ptr, list(shape) if shape is not None else []),)
return (ShapedArray(data_ptr, list(shape)),)

@impl(onnx.ReshapeOp)
def run_reshape(
Expand Down