-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pip prod(deps): bump pyright from 1.1.393 to 1.1.394 #3894
Conversation
Bumps [pyright](https://github.com/RobertCraigie/pyright-python) from 1.1.393 to 1.1.394. - [Release notes](https://github.com/RobertCraigie/pyright-python/releases) - [Commits](RobertCraigie/pyright-python@v1.1.393...v1.1.394) --- updated-dependencies: - dependency-name: pyright dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3894 +/- ##
==========================================
+ Coverage 91.25% 91.29% +0.03%
==========================================
Files 466 466
Lines 57945 58012 +67
Branches 5575 5566 -9
==========================================
+ Hits 52879 52962 +83
+ Misses 3635 3622 -13
+ Partials 1431 1428 -3 ☔ View full report in Codecov by Sentry. |
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
No idea how to fix this |
These seem like bugs to me |
In pyright? |
Yeah |
One thing I managed to reduce: microsoft/pyright#9917 |
Looking at the list of new failures, it looks like they're all of this type. |
I propose waiting for the release with the fix. |
As explained in my issue, this is an intentional change, and won't be fixed, I'll make the fix in our code now. |
So the error is caused by python letting things be equal even if the types don't match. |
Bumps pyright from 1.1.393 to 1.1.394.
Commits
70eb305
[pyright updated to 1.1.394] Update Version (#333)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)