Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip prod(deps): bump pyright from 1.1.393 to 1.1.394 #3894

Merged
merged 3 commits into from
Feb 17, 2025

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 13, 2025

Bumps pyright from 1.1.393 to 1.1.394.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [pyright](https://github.com/RobertCraigie/pyright-python) from 1.1.393 to 1.1.394.
- [Release notes](https://github.com/RobertCraigie/pyright-python/releases)
- [Commits](RobertCraigie/pyright-python@v1.1.393...v1.1.394)

---
updated-dependencies:
- dependency-name: pyright
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Feb 13, 2025
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.29%. Comparing base (9d7e16e) to head (e9a5afa).
Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3894      +/-   ##
==========================================
+ Coverage   91.25%   91.29%   +0.03%     
==========================================
  Files         466      466              
  Lines       57945    58012      +67     
  Branches     5575     5566       -9     
==========================================
+ Hits        52879    52962      +83     
+ Misses       3635     3622      -13     
+ Partials     1431     1428       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexarice alexarice closed this Feb 13, 2025
@alexarice alexarice reopened this Feb 13, 2025
Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 13, 2025

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@alexarice
Copy link
Collaborator

No idea how to fix this

@superlopuh
Copy link
Member

These seem like bugs to me

@alexarice
Copy link
Collaborator

In pyright?

@superlopuh
Copy link
Member

Yeah

@superlopuh
Copy link
Member

One thing I managed to reduce: microsoft/pyright#9917

@superlopuh
Copy link
Member

Looking at the list of new failures, it looks like they're all of this type.

@superlopuh
Copy link
Member

I propose waiting for the release with the fix.

@superlopuh
Copy link
Member

As explained in my issue, this is an intentional change, and won't be fixed, I'll make the fix in our code now.

@superlopuh
Copy link
Member

So the error is caused by python letting things be equal even if the types don't match.

@superlopuh superlopuh merged commit 8bc2d6b into main Feb 17, 2025
16 checks passed
@superlopuh superlopuh deleted the dependabot/pip/pyright-1.1.394 branch February 17, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants