Add clientInfo to ACP initialize request #181
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add client identification to the ACP initialize request so that when agent-shell connects to an ACP server, it identifies itself with name 'agent-shell', title 'Agent Shell', and the current package version. This follows the ACP protocol specification which includes clientInfo in the initialize request params.
xenodium
requested changes
Jan 9, 2026
| (cons `(clientInfo . ((name . "agent-shell") | ||
| (title . "Agent Shell") | ||
| (version . ,agent-shell--version))) | ||
| params)) |
Owner
There was a problem hiding this comment.
Let's extend acp-make-initialize-request in acp.el (adding a :client-info param). It would simplify usage from agent-shell.
Mind submitting a PR to https://github.com/xenodium/acp.el first? It would enable agent-shell usage like:
(acp-make-initialize-request
:protocol-version 1
:client-info `((name . "agent-shell")
(title . "Agent Shell")
(version . ,agent-shell--version))
:read-text-file-capability agent-shell-text-file-capabilities
:write-text-file-capability agent-shell-text-file-capabilities)
Owner
|
Thanks for the PR! We can likely split this PR into two. One in agent-shell and another in acp.el simplify usage between the two. Left a comment with more details. |
Owner
|
Hi @tulga-bytes Just checking in here... still keen to get this in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds client identification to the ACP initialize request so that when agent-shell connects to an ACP server, it identifies itself properly.
Changes
In the
agent-shell--initiate-handshakefunction, the initialize request now includes aclientInfoobject with:name:"agent-shell"- for programmatic/logical usetitle:"Agent Shell"- for UI/end-user contextsversion: dynamically uses theagent-shell--versionconstantProtocol Reference
This follows the ACP protocol specification which defines
clientInfoas part of the initialize request params.Pull Request opened by Augment Code with guidance from the PR author