Skip to content

Add clientInfo to ACP initialize request #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tulga-bytes wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add clientInfo to ACP initialize request #181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 40 additions & 32 deletions agent-shell.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2265,38 +2265,46 @@ Must provide ON-INITIATED (lambda ())."
:block-id "starting"
:body "\n\nInitializing..."
:append t))
(acp-send-request
:client (map-elt agent-shell--state :client)
:request (acp-make-initialize-request
:protocol-version 1
:read-text-file-capability agent-shell-text-file-capabilities
:write-text-file-capability agent-shell-text-file-capabilities)
:on-success (lambda (response)
(with-current-buffer (map-elt shell :buffer)
;; Save prompt capabilities from agent, converting to internal symbols
(when-let ((prompt-capabilities
(map-nested-elt response '(agentCapabilities promptCapabilities))))
(map-put! agent-shell--state :prompt-capabilities
(list (cons :image (map-elt prompt-capabilities 'image))
(cons :embedded-context (map-elt prompt-capabilities 'embeddedContext)))))
;; Save available modes from agent, converting to internal symbols
(when-let ((modes (map-elt response 'modes)))
(map-put! agent-shell--state :available-modes
(list (cons :current-mode-id (map-elt modes 'currentModeId))
(cons :modes (mapcar (lambda (mode)
`((:id . ,(map-elt mode 'id))
(:name . ,(map-elt mode 'name))
(:description . ,(map-elt mode 'description))))
(map-elt modes 'availableModes))))))
(when-let ((agent-capabilities (map-elt response 'agentCapabilities)))
(agent-shell--update-fragment
:state agent-shell--state
:block-id "agent_capabilities"
:label-left (propertize "Agent capabilities" 'font-lock-face 'font-lock-doc-markup-face)
:body (agent-shell--format-agent-capabilities agent-capabilities))))
(funcall on-initiated))
:on-failure (agent-shell--make-error-handler
:state agent-shell--state :shell shell)))
(let* ((request (acp-make-initialize-request
:protocol-version 1
:read-text-file-capability agent-shell-text-file-capabilities
:write-text-file-capability agent-shell-text-file-capabilities))
(params (cdr (assq :params request))))
;; Add clientInfo to the initialize request params
(setcdr (assq :params request)
(cons `(clientInfo . ((name . "agent-shell")
(title . "Agent Shell")
(version . ,agent-shell--version)))
params))
Copy link
Owner

@xenodium xenodium Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's extend acp-make-initialize-request in acp.el (adding a :client-info param). It would simplify usage from agent-shell.

Mind submitting a PR to https://github.com/xenodium/acp.el first? It would enable agent-shell usage like:

(acp-make-initialize-request
 :protocol-version 1
 :client-info `((name . "agent-shell")
                (title . "Agent Shell")
                (version . ,agent-shell--version))
 :read-text-file-capability agent-shell-text-file-capabilities
 :write-text-file-capability agent-shell-text-file-capabilities)

(acp-send-request
:client (map-elt agent-shell--state :client)
:request request
:on-success (lambda (response)
(with-current-buffer (map-elt shell :buffer)
;; Save prompt capabilities from agent, converting to internal symbols
(when-let ((prompt-capabilities
(map-nested-elt response '(agentCapabilities promptCapabilities))))
(map-put! agent-shell--state :prompt-capabilities
(list (cons :image (map-elt prompt-capabilities 'image))
(cons :embedded-context (map-elt prompt-capabilities 'embeddedContext)))))
;; Save available modes from agent, converting to internal symbols
(when-let ((modes (map-elt response 'modes)))
(map-put! agent-shell--state :available-modes
(list (cons :current-mode-id (map-elt modes 'currentModeId))
(cons :modes (mapcar (lambda (mode)
`((:id . ,(map-elt mode 'id))
(:name . ,(map-elt mode 'name))
(:description . ,(map-elt mode 'description))))
(map-elt modes 'availableModes))))))
(when-let ((agent-capabilities (map-elt response 'agentCapabilities)))
(agent-shell--update-fragment
:state agent-shell--state
:block-id "agent_capabilities"
:label-left (propertize "Agent capabilities" 'font-lock-face 'font-lock-doc-markup-face)
:body (agent-shell--format-agent-capabilities agent-capabilities))))
(funcall on-initiated))
:on-failure (agent-shell--make-error-handler
:state agent-shell--state :shell shell))))

(cl-defun agent-shell--authenticate (&key shell on-authenticated)
"Initiate ACP authentication with SHELL.
Expand Down