Handle GitHub removing Py27 and move pytype from to Py3.8 to fix issues #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernhardkaindl
force-pushed
the
pytype-no-xfails-no-excludes
branch
from
29179de
to
2f6fdd8
Compare
Codecov Report
@@ Coverage Diff @@
## master #93 +/- ##
==========================================
+ Coverage 77.59% 80.83% +3.23%
==========================================
Files 21 21
Lines 3468 3480 +12
==========================================
+ Hits 2691 2813 +122
+ Misses 777 667 -110
Flags with carried forward coverage won't be shown. Click here to find out more. |
bernhardkaindl
changed the title
bernhardkaindl
changed the title
psafont
reviewed
Jun 14, 2023
psafont
approved these changes
Jun 14, 2023
GeraldEV
reviewed
Jun 19, 2023
As pytype errors are fixed, clear excludes and xfails Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
- pytype has several problems to import libraries when used on Python 3.10, therefore move it Python 3.8. - tox.ini, GitHub CI: Remove builds for 3.7 and 3.9 builds because they showed intermittent pytest failures and we shoud not used them as new Python versions anyways. Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
bernhardkaindl
force-pushed
the
pytype-no-xfails-no-excludes
branch
7 times, most recently
from
736de04
to
afe42c7
Compare
As GitHub removed Python 2.7 from the ubuntu-20.04 rootfs, use a wrapper for setup-python which can build missing Python versions. Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
- remove running pytest for py311-pyre: It means we run pytest for: tox -e py38-covcombine (Py3.8 and 2.7) -e py36-lint and -e py310-check - run pyright after pyre to show annotations in GitHub code reviews Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
bernhardkaindl
force-pushed
the
pytype-no-xfails-no-excludes
branch
from
afe42c7
to
6c059b6
Compare
bernhardkaindl
changed the title
GeraldEV
approved these changes
Jun 20, 2023
bernhardkaindl
added a commit
to rosslagerwall/python-libs
that referenced
this pull request
May 8, 2024
…cks, fix saving all log messages (xenserver#92) * CP-48447: Fix Python3 handling Exceptions from func_output calls * CA-390127: Fix adding even the last log() messages to the output archive (xenserver#93) Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Because of the announcement of removal of Python 2.7 for setup-python in actions/setup-python#672, use a wrapper for setup-python which can build missing Python versions.
Commits:
run-pytype.py: Empty the list of excludes and xfails
tox.ini and CI: Move pytype to Py3.8 and remove 3.7 and 3.9 builds
.github/workflows/main.yml: Py2.7: Use a wrapper for setup-python